1335331 - As a user, I want the ability to change email address

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Matjaz Horvat [:mathjazz]]

Users should be able to change their email addresses.

Comment 1

[jozefkarabelly]

Hello can I work on this bug?

Comment 2

[Jarek Śmiejczak [:jotes]]

:jozefkarabelly

I think you can, feel free to ask if you have any questions :-)

Comment 3

[jozefkarabelly]

(In reply to Jarek from comment #2)
> :jozefkarabelly
> 
> I think you can, feel free to ask if you have any questions :-)
I do, I am not sure how to implement this, should I do this just like username view or create profile view where I will handle both username and email?

Comment 4

[Matjaz Horvat [:mathjazz]]

We should have fields for changing the username and email in the /settings, checkout the attached screenshot.

We should also get rid of the username changing UI in both /profile and /settings. It's fun, but not very obvious.

Comment 5

[Matjaz Horvat [:mathjazz]]

Attachment: Possible email and name changing UI

Comment 6

[jozefkarabelly]

Attachment: Profile form

Can it be like this?

Comment 7

[Matjaz Horvat [:mathjazz]]

I'd actually keep the #heading look unchanged and add the new fields to #main, just above the prefered locales block.

Comment 8

[jozefkarabelly]

:mathjazz

Who shall I add to pull request as reviewer?

Comment 9

[Matjaz Horvat [:mathjazz]]

I'd be happy to review!

Comment 10

[Michael]

Is this bug fixed yet? I interested to take it on if possible.

Comment 11

[Matjaz Horvat [:mathjazz]]

Hi Michael,

We already have a PR pending for this bug that is waiting for a review:
https://github.com/mozilla/pontoon/pull/631

If you want, you can pick one of our mentored bugs, for example bug 1398852.

There's a full list of mentored bugs to pick from:
https://wiki.mozilla.org/Webdev/GetInvolved/pontoon.mozilla.org

If none of them is of your interest, I'd be happy to help you find a different one.

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/793

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/702d1e1fff7c0952431856635adbc5112fc9d208
Fix bug 1335331 - Enable users to change their email address (#793)

* Bug 1335331: added ability to change email address

* Bug 1335331: add username in read-only mode

* Bug 1335331: remove placeholders

* Bug 1335331: add email validation

* Bug 1335331: adjust contributor profile tests

* Bug 1335331: make profile-form submit more generic

* Bug 1335331: add logout after email change

* Bug 1335331: change email in tests

* Bug 1335331: add email warning message to css

* Bug 1335331: adjust contributor profile test email

* Bug 1335331: shorten the line to pass PEP8

* Bug 1335331: make code style consistent

* Bug 1335331: correct level of indentation

* Fix errors on settings page.
This commit removes the fancy javascript that allowed to save user profile without reloading the page. It was a big source of errors and complexity. The settings page is now much simpler, the custom home page being the only exception. This fixes the CSRF error that was happening as well when saving data by clicking the Save button.

* Show or hide warning using JS.
It was bad that the warning for a changed email would only appear on focus on the input. First it made it difficult to click the save button, as the layout was changed and thus the button moved. Second, it would show up even if the email was not changed.
This commit also moves CSS to the more specific settings.css file, and addresses a few review comments.

* Make message a help text instead, and always show it.

* Styling changes.

Comment 14

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Nice job, only a minor note - the field for the name should probably be labeled "Name", not "First name".

Comment 15

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/820

Comment 16

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/75b3ffe350d017f9e808511a327c58f8327b7e4a
Bug 1335331: Rename first_name to name (#820)