1335365 - Add telemetry to see if we can remove XHR.reponseType moz-blob

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: xhr_telemetry.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8831999 [details] [diff] [review]
xhr_telemetry.patch

why
"expires_in_version": "never", ?
Collecting just some time should be enough. FF54 or FF55?

So the idea is to detect whether anyone uses moz-blob and just collect the submission numbers, not compare use of moz-blob to others?


I think we should add telemetry for all the moz-* types
http://searchfox.org/mozilla-central/rev/4e0c5c460318fb9ef7d92b129ac095ce04bc4795/dom/webidl/XMLHttpRequest.webidl#26-28
With that, r+, but bsmedberg may have an opinion.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: xhr_telemetry.patch

Comment 4

[Benjamin Smedberg]

Comment on attachment 8832040 [details] [diff] [review]
xhr_telemetry.patch

These can be count histograms instead of booleans (you never record `false` so the bool is unnecessary).

Just a note for the record that since telemetry.mozilla.org doesn't show the opt-out data, you'll need to use a custom query to get the release data. And getting the release data is important for this because beta isn't representative for many webcompat questions.

I did not review the code.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a08d65d594ba
Add telemetry to see if we can remove moz-only XHR.reponseType, r=smaug, data-review=bsmedberg

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/683b87b736e9
Add telemetry to see if we can remove moz-only XHR.reponseType, r=me CLOSED TREE

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a08d65d594ba
https://hg.mozilla.org/mozilla-central/rev/683b87b736e9

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8832040 [details] [diff] [review]
xhr_telemetry.patch

Approval Request Comment
[Feature/Bug causing the regression]: None. We would like to have results quickly
[User impact if declined]: none
[Is this code covered by automated tests?]: no needs.
[Has the fix been verified in Nightly?]: no needs.
[Needs manual test from QE? If yes, steps to reproduce]: no needs. 
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: it adds some telemetry IDs. These are useful to know if we can get rid of mozilla-only XHR response types.
[String changes made/needed]: none

Comment 9

[Julien Cristau [:jcristau]]

I guess this wants to go in aurora as well, since it's set to expire in 58, not 53?

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8832040 [details] [diff] [review]
xhr_telemetry.patch

new telemetry probes, aurora53+, beta52+

Comment 11

[Carsten Book [:Tomcat]]

needs rebasing for aurora

Comment 12

[Andrea Marchesini [:baku]]

Attachment: m-a

Comment 13

[Andrea Marchesini [:baku]]

Attachment: m-b

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e18063003cdf

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8f077c42aed8