Closed Bug 1335365 Opened 7 years ago Closed 7 years ago

Add telemetry to see if we can remove XHR.reponseType moz-blob


(Core :: DOM: Core & HTML, defect)

49 Branch
Not set



Tracking Status
firefox52 --- fixed
firefox53 --- fixed
firefox54 --- fixed


(Reporter: baku, Assigned: baku)




(3 files, 1 obsolete file)

      No description provided.
Attached patch xhr_telemetry.patch (obsolete) — Splinter Review
Assignee: nobody → amarchesini
Attachment #8831999 - Flags: review?(bugs)
Comment on attachment 8831999 [details] [diff] [review]

"expires_in_version": "never", ?
Collecting just some time should be enough. FF54 or FF55?

So the idea is to detect whether anyone uses moz-blob and just collect the submission numbers, not compare use of moz-blob to others?

I think we should add telemetry for all the moz-* types
With that, r+, but bsmedberg may have an opinion.
Attachment #8831999 - Flags: review?(bugs) → review+
Attachment #8831999 - Attachment is obsolete: true
Attachment #8832040 - Flags: review?(benjamin)
Comment on attachment 8832040 [details] [diff] [review]

These can be count histograms instead of booleans (you never record `false` so the bool is unnecessary).

Just a note for the record that since doesn't show the opt-out data, you'll need to use a custom query to get the release data. And getting the release data is important for this because beta isn't representative for many webcompat questions.

I did not review the code.
Attachment #8832040 - Flags: review?(benjamin) → review+
Pushed by
Add telemetry to see if we can remove moz-only XHR.reponseType, r=smaug, data-review=bsmedberg
Pushed by
Add telemetry to see if we can remove moz-only XHR.reponseType, r=me CLOSED TREE
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment on attachment 8832040 [details] [diff] [review]

Approval Request Comment
[Feature/Bug causing the regression]: None. We would like to have results quickly
[User impact if declined]: none
[Is this code covered by automated tests?]: no needs.
[Has the fix been verified in Nightly?]: no needs.
[Needs manual test from QE? If yes, steps to reproduce]: no needs. 
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: it adds some telemetry IDs. These are useful to know if we can get rid of mozilla-only XHR response types.
[String changes made/needed]: none
Attachment #8832040 - Flags: approval-mozilla-beta?
I guess this wants to go in aurora as well, since it's set to expire in 58, not 53?
Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Attachment #8832040 - Flags: approval-mozilla-aurora?
Comment on attachment 8832040 [details] [diff] [review]

new telemetry probes, aurora53+, beta52+
Attachment #8832040 - Flags: approval-mozilla-beta?
Attachment #8832040 - Flags: approval-mozilla-beta+
Attachment #8832040 - Flags: approval-mozilla-aurora?
Attachment #8832040 - Flags: approval-mozilla-aurora+
needs rebasing for aurora
Flags: needinfo?(amarchesini)
Attached patch m-aSplinter Review
Flags: needinfo?(amarchesini)
Attached patch m-bSplinter Review
Attachment #8832472 - Attachment is patch: true
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.