Closed Bug 1335365 Opened 7 years ago Closed 7 years ago
Add telemetry to see if we can remove XHR
.reponse Type moz-blob
No description provided.
Assignee: nobody → amarchesini
Attachment #8831999 - Flags: review?(bugs)
Comment on attachment 8831999 [details] [diff] [review] xhr_telemetry.patch why "expires_in_version": "never", ? Collecting just some time should be enough. FF54 or FF55? So the idea is to detect whether anyone uses moz-blob and just collect the submission numbers, not compare use of moz-blob to others? I think we should add telemetry for all the moz-* types http://searchfox.org/mozilla-central/rev/4e0c5c460318fb9ef7d92b129ac095ce04bc4795/dom/webidl/XMLHttpRequest.webidl#26-28 With that, r+, but bsmedberg may have an opinion.
Attachment #8831999 - Flags: review?(bugs) → review+
Comment on attachment 8832040 [details] [diff] [review] xhr_telemetry.patch These can be count histograms instead of booleans (you never record `false` so the bool is unnecessary). Just a note for the record that since telemetry.mozilla.org doesn't show the opt-out data, you'll need to use a custom query to get the release data. And getting the release data is important for this because beta isn't representative for many webcompat questions. I did not review the code.
Attachment #8832040 - Flags: review?(benjamin) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a08d65d594ba Add telemetry to see if we can remove moz-only XHR.reponseType, r=smaug, data-review=bsmedberg
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/683b87b736e9 Add telemetry to see if we can remove moz-only XHR.reponseType, r=me CLOSED TREE
Comment on attachment 8832040 [details] [diff] [review] xhr_telemetry.patch Approval Request Comment [Feature/Bug causing the regression]: None. We would like to have results quickly [User impact if declined]: none [Is this code covered by automated tests?]: no needs. [Has the fix been verified in Nightly?]: no needs. [Needs manual test from QE? If yes, steps to reproduce]: no needs. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: it adds some telemetry IDs. These are useful to know if we can get rid of mozilla-only XHR response types. [String changes made/needed]: none
I guess this wants to go in aurora as well, since it's set to expire in 58, not 53?
Attachment #8832040 - Flags: approval-mozilla-aurora?
Comment on attachment 8832040 [details] [diff] [review] xhr_telemetry.patch new telemetry probes, aurora53+, beta52+
needs rebasing for aurora
Attachment #8832472 - Attachment is patch: true
You need to log in before you can comment on or make changes to this bug.