1335444 - Consider enabling stack capturing for non-profiler Win32 builds

Status: NEW

(Toolkit :: Telemetry, defect, P3)

Description

[Georg Fritzsche [:gfritzsche]]

(In reply to Eric Rahm [:erahm] from bug 1209131, comment #18)
> (In reply to Georg Fritzsche [:gfritzsche] [away Jan 14 - 24] from comment
> #17)
> > (Eric Rahm [:erahm] on bug, comment #63)
> > > I see what you're saying now, yes this improvement is not isolated to
> > > crashes. It should help with getting useful stack traces across the board on
> > > win32. Bug 1209131 seems to be limiting itself to builds that have profiling
> > > enabled so that might be an issue as this doesn't change when profiling is
> > > enabled. That conversation is probably better discussed in that bug.
> > 
> > Do i understand this right that, with bug 1322735 landed, we should be able
> > to enable the stack capturing here for all Win32 builds?
> 
> Correct!

If we do this we have to consider the performance implications.
I.e. how many people would this affect with the expensive capture operations?

Comment 1

[Georg Fritzsche [:gfritzsche]]

See also bug 1316088, comment 1.

Comment 2

[Eric Rahm [:erahm]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #0)
> If we do this we have to consider the performance implications.
> I.e. how many people would this affect with the expensive capture operations?

It depends how often we're capturing stacks. For example, if it's for diagnostic asserts in theory it should be rare (and in debug builds they'd crash anyhow, so degraded perf maybe isn't such a big deal).

Where are we planning on using this?