1335490 - Impossible to push because the tree-status hook fails to read some values.

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Nicolas B. Pierron [:nbp]]

The tree status reported on treeherder keeps showing question marks by intermitence, I think this might be related to this failure.

STR:
 - Push some changes to try:

Seen:

remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 23 changesets with 5 changes to 39 files (+1 heads)
remote: error: pretxnchangegroup.a_treeclosure hook raised an exception: 'result'
remote: transaction abort!
remote: rollback completed
remote: ** Unknown exception encountered with possibly-broken third-party extension vcsreplicator
remote: ** which supports versions 3.7 of Mercurial.
remote: ** Please disable vcsreplicator and try your action again.
remote: ** If that fixes the bug please report it to the extension author.
remote: ** Python 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
remote: ** Mercurial Distributed SCM (version 4.0.1)
remote: ** Extensions loaded: blackbox, clonebundles, bundleclone, obsolescencehacks, pushlog, serverlog, readonly, vcsreplicator
remote: Traceback (most recent call last):
remote:   File "/var/hg/venv_pash/bin/hg", line 45, in <module>
remote:     mercurial.dispatch.run()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 60, in run
remote:     sys.exit((dispatch(request(sys.argv[1:])) or 0) & 255)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 126, in dispatch
remote:     ret = _runcatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 216, in _runcatch
remote:     return callcatch(ui, _runcatchfunc)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 225, in callcatch
remote:     return func()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 205, in _runcatchfunc
remote:     return _dispatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 901, in _dispatch
remote:     cmdpats, cmdoptions)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 650, in runcommand
remote:     ret = _runcommand(ui, options, cmd, d)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 909, in _runcommand
remote:     return cmdfunc()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 898, in <lambda>
remote:     d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/util.py", line 1037, in check
remote:     return func(*args, **kwargs)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/commands.py", line 6575, in serve
remote:     s.serve_forever()
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 320, in serve_forever
remote:     return super(sshserverwrapped, self).serve_forever()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 104, in serve_forever
remote:     while self.serve_one():
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 351, in serve_one
remote:     return super(sshserverwrapped, self).serve_one()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 122, in serve_one
remote:     rsp = wireproto.dispatch(self.repo, self, cmd)
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 343, in dispatch
remote:     return origdispatch(repo, proto, cmd)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/extensions.py", line 220, in closure
remote:     return func(*(args + a), **kw)
remote:   File "/var/hg/version-control-tools/pylib/vcsreplicator/vcsreplicator/hgext.py", line 359, in wireprotodispatch
remote:     return orig(repo, proto, command)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 575, in dispatch
remote:     return func(repo, proto, *args)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 899, in unbundle
remote:     proto._client())
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/exchange.py", line 1745, in unbundle
remote:     r = cg.apply(repo, source, url)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/changegroup.py", line 374, in apply
remote:     repo.hook('pretxnchangegroup', throw=True, **hookargs)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/localrepo.py", line 600, in hook
remote:     return hook.hook(self.ui, self, name, throw, **args)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/hook.py", line 205, in hook
remote:     res = runhooks(ui, repo, name, hooks, throw=throw, **args)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/hook.py", line 255, in runhooks
remote:     throw)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/hook.py", line 99, in _pythonhook
remote:     r = obj(ui=ui, repo=repo, hooktype=name, **args)
remote:   File "/var/hg/version-control-tools/hghooks/mozhghooks/treeclosure.py", line 70, in hook
remote:     return 0 if isPushAllowed(repo, treestatus_name) else 1
remote:   File "/var/hg/version-control-tools/hghooks/mozhghooks/treeclosure.py", line 39, in isPushAllowed
remote:     if data['result']['status'] == 'closed':
remote: KeyError: 'result'

Comment 1

[Nicolas B. Pierron [:nbp]]

garbas> nbp: rolledback to old treestatus