1335506 - Only show the Trigger Missing Jobs button on a whitelist of trees which do SETA-based scheduling

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

11:31:10 <philor> speaking of which, I don't think anyone but me ever really used "Trigger missing jobs" but if you do, DON'T
11:31:58 <KWierso> philor: I used it a couple times
11:32:00 <philor> since my triggering of missing jobs 11 days ago resulted in a l10n nightly job ten days later, and a periodicupdate job 11 days later
11:32:01 <KWierso> but won't now
11:33:30 <philor> suppose we should probably get treeherder to remove the UI until the bot gets a letter of fitness from its psychiatrist
11:35:41 <KWierso> philor: can do

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:hidetriggermissingjobs > mozilla:master

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8832165 [details] [review]
[treeherder] KWierso:hidetriggermissingjobs > mozilla:master

Haha.  Perhaps the shortest review I've ever had.  :)  Before merge, would you please add a comment with a bug number to the bug about fixing triggering so we know why it's been hidden?

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e91d597ff741d0c5d6c2eb2fcf23aaac2f07a827
Bug 1335506 - Hide the trigger missing jobs button until it behaves (#2121) r=camd

Comment 4

[Ed Morley [:emorley]]

Unfortunately this caused a parse error during the Grunt build:
https://travis-ci.org/mozilla/treeherder/jobs/198363137#L280

...not sure why this didn't fail the Travis job.

I'll revert for now, so we can do a prod push, and file a separate bug for debugging why the JS Travis job doesn't show as failed.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8d09162f763122a0a6c2f1bb474915079cb549ea
Revert "Bug 1335506 - Hide the trigger missing jobs button until it behaves (#2121) r=camd"

This reverts commit e91d597ff741d0c5d6c2eb2fcf23aaac2f07a827.

Comment 6

[Phil Ringnalda (:philor)]

Probably a better workaround, or perhaps permanent fix, would be to only have it enabled on a whitelist of trees consisting of mozilla-inbound and autoland.

The temptation to trigger it on mozilla-beta just to see whether or not it would try to trigger jobs which appear in allthethings like release-mozilla-beta-firefox-win64_partner_repacks or release-mozilla-beta-firefox_version_bump is killing me.

Comment 8

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:triggermissingv2 > mozilla:master

Comment 9

[Cameron Dawson [:camd]]

Requested a change in the PR.  Thanks. :)

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0361b618af8448d68415adec2386d59f3edecd16
Bug 1335506 - Only show Trigger Missing Jobs on integration branches (#2342) r=camd

* Bug 1335506 - Only show Trigger Missing Jobs on integration branches