MediaEngine.h fails to compile with --disable-webrtc

RESOLVED FIXED in Firefox 54

Status

()

Core
WebRTC
P1
normal
Rank:
15
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mats, Assigned: mats)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
libdom_bindings.a.desc
In file included from dom/media/Unified_cpp_dom_media1.cpp:137:
In file included from dom/media/MediaDeviceInfo.cpp:7:
In file included from dist/include/mozilla/MediaManager.h:8:
dist/include/MediaEngine.h:229:28: error: reference to 'ipc' is ambiguous
                     const ipc::PrincipalInfo& aPrincipalInfo,
                           ^
ipc/ipdl/_ipdlheaders/mozilla/ipc/PBackgroundSharedTypes.h:577:11: note: candidate found by name lookup is 'mozilla::ipc'
namespace ipc {
          ^
dist/include/mozilla/dom/ipc/StructuredCloneData.h:33:11: note: candidate found by name lookup is 'mozilla::dom::ipc'
namespace ipc {
          ^
(Assignee)

Comment 1

a year ago
Created attachment 8832179 [details] [diff] [review]
fix
Assignee: nobody → mats
Attachment #8832179 - Flags: review?(cpearce)

Updated

a year ago
Rank: 15
Priority: -- → P1
Comment on attachment 8832179 [details] [diff] [review]
fix

Review of attachment 8832179 [details] [diff] [review]:
-----------------------------------------------------------------

This is WebRTC code, not playback, so passing review to Jesup.
Attachment #8832179 - Flags: review?(cpearce) → review?(rjesup)
Attachment #8832179 - Flags: review?(rjesup) → review+

Comment 3

a year ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00aaf25b6e05
Add mozilla:: prefix to make MediaEngine.h compile with --disable-webrtc.  r=jesup
Part of this already landed in Bug 1335250; I landed the remaining line.

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/00aaf25b6e05
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.