1335515 - MediaEngine.h fails to compile with --disable-webrtc

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Mats Palmgren (inactive)]

libdom_bindings.a.desc
In file included from dom/media/Unified_cpp_dom_media1.cpp:137:
In file included from dom/media/MediaDeviceInfo.cpp:7:
In file included from dist/include/mozilla/MediaManager.h:8:
dist/include/MediaEngine.h:229:28: error: reference to 'ipc' is ambiguous
                     const ipc::PrincipalInfo& aPrincipalInfo,
                           ^
ipc/ipdl/_ipdlheaders/mozilla/ipc/PBackgroundSharedTypes.h:577:11: note: candidate found by name lookup is 'mozilla::ipc'
namespace ipc {
          ^
dist/include/mozilla/dom/ipc/StructuredCloneData.h:33:11: note: candidate found by name lookup is 'mozilla::dom::ipc'
namespace ipc {
          ^

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8832179 [details] [diff] [review]
fix

Review of attachment 8832179 [details] [diff] [review]:
-----------------------------------------------------------------

This is WebRTC code, not playback, so passing review to Jesup.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00aaf25b6e05
Add mozilla:: prefix to make MediaEngine.h compile with --disable-webrtc.  r=jesup

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Part of this already landed in Bug 1335250; I landed the remaining line.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/00aaf25b6e05