Closed
Bug 1335632
Opened 7 years ago
Closed 7 years ago
Split out the const and mutable parts of myTrustedEVInfos
Categories
(Core :: Security: PSM, defect, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(2 files)
50.53 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
8.12 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
Followup from bug 1335294 comment 2.
Priority: -- → P1
Whiteboard: [psm-assigned]
.rdata: 5536 bytes change .data: -5760 bytes change The first few lines I removed weren't being used anywhere. The number 8 in the comment wasn't update last time this file was touched. It should have been 7, now 6.
Attachment #8837865 -
Flags: review?(dkeeler)
Attachment #8837831 -
Flags: review?(dkeeler)
Attachment #8837831 -
Flags: review?(dkeeler) → review+
Comment on attachment 8837865 [details] [diff] [review] Split out oid_tag Review of attachment 8837865 [details] [diff] [review]: ----------------------------------------------------------------- Awesome - just a few nits. ::: security/certverifier/ExtendedValidation.cpp @@ +47,5 @@ > // > // You will need the output from sections "Issuer", "Fingerprint (SHA-256)", > // "Issuer DER Base64" and "Serial DER Base64". > // > +// The new section consists of 6 lines: I might just leave out the specific number and say something like "The new section consists of the following components:" @@ +1140,5 @@ > "Cn6m30tEntpqJIWe5rgV0xZ/u7E=", > }, > }; > > +static SECOidTag oid_tags[mozilla::ArrayLength(myTrustedEVInfos)]; Maybe we should call this something like sEVInfoOIDTags? @@ +1169,5 @@ > if (policyOIDTag != SEC_OID_UNKNOWN && policyOIDTag == sCABForumEVOIDTag) { > return true; > } > > + for (const SECOidTag& entry : oid_tags) { Maybe oidTag? or evOIDTag? @@ +1200,5 @@ > > const SECOidData* cabforumOIDData = SECOID_FindOIDByTag(sCABForumEVOIDTag); > + for (size_t iEV = 0; iEV < mozilla::ArrayLength(myTrustedEVInfos); ++iEV) { > + const nsMyTrustedEVInfo& entry = myTrustedEVInfos[iEV]; > + nit: there's some trailing whitespace on this line
Attachment #8837865 -
Flags: review?(dkeeler) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/efe205d42f03 Split out the const and mutable parts of myTrustedEVInfos. r=keeler
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/efe205d42f03
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•