1335632 - Split out the const and mutable parts of myTrustedEVInfos

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[(Away)]

Followup from bug 1335294 comment 2.

Comment 1

[(Away)]

Attachment: grep -v " SEC_OID_UNKNOWN," (will fold into next patch)

Splitting out the mechanical changes for ease of review

Comment 2

[(Away)]

Attachment: Split out oid_tag

.rdata:    5536 bytes change
       .data:   -5760 bytes change

The first few lines I removed weren't being used anywhere. 

The number 8 in the comment wasn't update last time this file was touched. It should have been 7, now 6.

Comment 3

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8837865 [details] [diff] [review]
Split out oid_tag

Review of attachment 8837865 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome - just a few nits.

::: security/certverifier/ExtendedValidation.cpp
@@ +47,5 @@
>  //
>  // You will need the output from sections "Issuer", "Fingerprint (SHA-256)",
>  // "Issuer DER Base64" and "Serial DER Base64".
>  //
> +// The new section consists of 6 lines:

I might just leave out the specific number and say something like "The new section consists of the following components:"

@@ +1140,5 @@
>      "Cn6m30tEntpqJIWe5rgV0xZ/u7E=",
>    },
>  };
>  
> +static SECOidTag oid_tags[mozilla::ArrayLength(myTrustedEVInfos)];

Maybe we should call this something like sEVInfoOIDTags?

@@ +1169,5 @@
>    if (policyOIDTag != SEC_OID_UNKNOWN && policyOIDTag == sCABForumEVOIDTag) {
>      return true;
>    }
>  
> +  for (const SECOidTag& entry : oid_tags) {

Maybe oidTag? or evOIDTag?

@@ +1200,5 @@
>  
>    const SECOidData* cabforumOIDData = SECOID_FindOIDByTag(sCABForumEVOIDTag);
> +  for (size_t iEV = 0; iEV < mozilla::ArrayLength(myTrustedEVInfos); ++iEV) {
> +    const nsMyTrustedEVInfo& entry = myTrustedEVInfos[iEV];
> +    

nit: there's some trailing whitespace on this line

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efe205d42f03
Split out the const and mutable parts of myTrustedEVInfos. r=keeler

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efe205d42f03