1335669 - Autophone - phonedash - ui upgrade

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Loading http://phonedash.mozilla.org/ does not automatically display a graph any more. The user is required to click Reset to load the data and then click Reset again to select and display the graph.

This turns out to be due to a change in how the date period and start/end dates fire onchange events. Previously, changing the date period or start/end dates fired two onchange events which we worked around by determining the default date range for today and setting the corresponding document.location.hash and returning early from displayGraph which would then be immediately called again which would then load and graph the data.

The simple fix is to remove the early return.

While we are here, we might as well improve some other items:

The default binning is repo-phonetype but this can cause the graph to erroneously appear to show improvements or regressions if the complete population of phones for the phonetype have not submitted recent data. The fix is to change the default binning to repo-phonetype-phoneid.

The colors for the graph lines are currently chosen automatically and when many series are displayed results in series with the color of white which does not display well on a background of white. The fix here is to use a standard set of colors and adjust the background. I've added the CSS standard color names and changed the background color to black which does not have the same failing as a white background when displaying lines with "light" colors.

Finally, we can take this opportunity to upgrade flot to 0.8.3 and jquery-ui to 1.12.1 and get the latest timezone tables.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/phonedash/pull/2

I figure a pull request makes more sense for this one.

It looks bigger than it is. I didn't trim the extra files from the updates to flot and jquery-ui so we have the full installations now.

Comment 2

[Bob Clary [:bc] (inactive)]

I've deployed the branch onto phonedash-dev. I don't have recent data in phonedash-dev, so you can't see the default today data loading, but you can see everything else using the range Oct 30 - Nov 1 2016:

http://phonedash-dev.allizom.org/#/2016-10-01/2016-11-01/local-blank=on&local-nytimes=on&local-twitter=on&remote-blank=on&remote-nytimes=on&remote-twitter=on&throbberstart=on&throbberstop=on&throbbertime=on&first=on&second=on&mozilla-central=on&nexus-5=on&nexus-5-2=on&nexus-5-3=on&nexus-5-5=on&nexus-6p=on&nexus-6p-10=on&nexus-6p-11=on&nexus-6p-12=on&nexus-6p-13=on&nexus-6p-14=on&nexus-6p-15=on&nexus-6p-16=on&nexus-6p-17=on&nexus-6p-18=on&nexus-6p-6=on&nexus-6p-9=on&samsung-gs3=on&samsung-gs3-3=on

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8832362 [details] [review]
https://github.com/mozilla/phonedash/pull/2

I really think adding all of the extra files in outside of the core .js libraries we want is not beneficial- maybe just getting rid of the examples folder would be a good happy medium?

Comment 4

[Bob Clary [:bc] (inactive)]

Comment on attachment 8832362 [details] [review]
https://github.com/mozilla/phonedash/pull/2

Removed examples and *.md and pushed the additional commit. I'll rebase it onto the flot commit before merging.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8832362 [details] [review]
https://github.com/mozilla/phonedash/pull/2

much fewer files

Comment 6

[Bob Clary [:bc] (inactive)]

I really should just write an installer that will download and unzip the flot, jquery-ui and tz stuff into the directory then we don't need to keep copies in the tree. Another bug for another time.

Comment 7

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/phonedash/commit/8f5b8ca9a221e78da0b61e56c801f068cfd70d89
https://github.com/mozilla/phonedash/commit/510184bac91f188ce387d804a6c4bc1afd0c5893
https://github.com/mozilla/phonedash/commit/02bea50a9c0ba136c0dfea705208375f139fb6b5
https://github.com/mozilla/phonedash/commit/496ac564f1ff7ed961062e5991ad2027d51cc00f
https://github.com/mozilla/phonedash/commit/cf263a46c5d869910a5335743896ca7cb1f75bba
https://github.com/mozilla/phonedash/commit/6e3e3d911bb474468b4461953a227c3ab2f3d717
deployed phonedash, phonedash-dev 2017-02-02 02:35