1335720 - Replace "Disable" with "Cancel" button in sideloaded-install pop-up

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Vasilica Tamas, QA [:vtamas]]

[Affected versions]:
Firefox 53.0a2 (2017-02-01)
Firefox 54.0a1 (2017-02-01)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Restart the browser.
4.Install via sideloading method the attached webextension. 
5.Go to Panel Menu [≡] and click on sideloading notification.


[Expected Results]:
“Disable” button should be replaced with “Cancel” button considering that the add-on is already disabled when the sideloaded-install pop-up is displayed.


[Actual Results]:
“Disable” button does nothing more than to close the sideloaded-install pop-up. ( https://www.screencast.com/t/mScIqGlyn )

Comment 1

[Andrew Swan [:aswan]]

This is as specified in bug 1316996.  Scott, what say you?

Comment 2

[sdevaney]

There was debate on this very topic earlier in the process (it actually was "Cancel" in the original mock-ups), with some in UX arguing "Cancel" could more easily be misconstrued as something else in this case.

But in reflection I think we should go with "Cancel" as it the more standard cadence. I'm fine reverting to this.

Comment 3

[Andrew Swan [:aswan]]

And what should the text in the dialog above say?  It currently says:
Another program on your computer installed an add-on that may affect your browser. Please review this add-on’s permissions requests and choose to Enable or Disable.

Comment 4

[sdevaney]

(In reply to Andrew Swan [:aswan] from comment #3)
> And what should the text in the dialog above say?  It currently says:
> Another program on your computer installed an add-on that may affect your
> browser. Please review this add-on’s permissions requests and choose to
> Enable or Disable.

Hm, yes, perhaps we could clarify there. How about: 

Another program on your computer installed an add-on that may affect your browser. Please review this add-on’s permissions requests and choose to Enable or Cancel (to leave it disabled).

Comment 5

[Andrew Swan [:aswan]]

Attachment: Bug 1335720 Update sideload notification text

Review commit: https://reviewboard.mozilla.org/r/110536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110536/

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8834704 [details]
Bug 1335720 Update sideload notification text

https://reviewboard.mozilla.org/r/110536/#review112264

Looks good.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cf80de42750
Update sideload notification text r=flod

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0cf80de42750

Comment 9

[Vasilica Tamas, QA [:vtamas]]

Verified as fixed on Firefox 54.0a1 (2017-02-16) under Windows 10 64-bit and Ubuntu 16.04 32-bit. 
The sideloaded-install doorhanger is correctly modified based on Comment 2 and Comment 4.