1335730 - FinderHighlighter.jsm leaks about:newtab

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

STR:

1) open new browser with findbar.modalHighlight set to true
2) open about:memory in a tab
3) hit ctrl-t to open a new tab (it should show about:newtab by default)
4) on about:newtab hit ctr-f and search for any random string
5) close the about:newtab tab
6) go to your about:memory tab, minimize, and measure
7) observe a detached about:newtab window

The GC/CC logs show this is being held alive by FinderHighlighter.jsm's gWindows Map:

via persistent-Object :
000001EA4691DE20 [BackstagePass 000001EA33DEFC40]
    --[**UNKNOWN SLOT 128**]--> 000001EA352158B0 [LexicalEnvironment <no private>]
    --[gWindows]--> 000001EA3E331A60 [Map 000001EA63F93E80]
    --[key]--> 000001EA38BDE180 [Proxy <no private>]
    --[private]--> 000001EA3B93D0E0 [Proxy <no private>]
    --[private]--> 000001EA3DB78100 [Window <no private>]


Mike, can you take a look at this?

Comment 1

[Mike de Boer [:mikedeboer]]

Yup! Thanks for filing.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1335730 - delete the map entry when a window unloads and is tracked by the FinderHighlighter.

Review commit: https://reviewboard.mozilla.org/r/110116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110116/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8834004 [details]
Bug 1335730 - delete the map entry when a window unloads and is tracked by the FinderHighlighter.

https://reviewboard.mozilla.org/r/110116/#review111126

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a087f3a3767
delete the map entry when a window unloads and is tracked by the FinderHighlighter. r=jaws

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a087f3a3767

Comment 6

[roxleitan]

Verified fixed using the latest Nightly 55.0a1(2017-04-25) and Nightly 54.0a1 (2017-02-11), with the preference "findbar.modalHighlight" set to true on  Windows 10 x64, Ubuntu 16.04 and Mac OS X 10.12.