1335799 - Update to WebRender 0b6af19f3539937717a3f651a7357a6d09ded032 and sort out ffi types

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Comment 2

[Nicolas Silva [:nical]]

Attachment: update to wr a63d0a224ec784c1caf8b08cdee9fbb0f6c35315

Comment 3

[Nicolas Silva [:nical]]

Attachment: update ffi/bindings

Comment 4

[Nicolas Silva [:nical]]

Still not landable, there are some reftests failing https://treeherder.mozilla.org/#/jobs?repo=try&revision=c57109d42b28870085ca684756db5724956754f1

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Some of these failures look like blend mode problems.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Some of these failures look like blend mode problems.

I'll look at these.

Comment 7

[Ryan Hunt [:rhunt]]

I believe this is causing the mix blend mode failures. The regresion is in the update range.

https://github.com/servo/webrender/issues/838

Comment 8

[Jeff Muizelaar [:jrmuizel]]

As Dzmitry pointed out, the clipping breakage is likely caused by https://github.com/servo/webrender/commit/303fa12f023fe163c5bbd2a01c78adfa09755ca1

Comment 9

[Ryan Hunt [:rhunt]]

The issue on github has been resolved and updating to a new WebRender (>512b4a1) should solve the mix-blend-mode issues.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Updating to a newer webrender should also get us better clipping support for scroll layers we will be needed going forward.

Comment 11

[Nicolas Silva [:nical]]

Attachment: update to wr 0b6af19f3539937717a3f651a7357a6d09ded032

Note: this patch doesn't take into account the coordinate system change for clips.

Comment 12

[Nicolas Silva [:nical]]

Attachment: update ffi/bindings

Comment 13

[Jeff Muizelaar [:jrmuizel]]

This should be landable:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7aaa994ef27da4e678c644b2a2c6a3f34cc207e9

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Rebased to graphics tip:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a9f1785d2ec794f9428f6d3dd4d3df1b0277946

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Note that if I did the rebase correctly, the try push above should be green except for R4/Ru4 failures which will show UNEXPECTED-PASS on dom/canvas/test/reftest/1177726-text-stroke-bounds-ref.html. That is expected and will be fixed when 4b9e865bb255 merges from central to graphics, so ignore that failures.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

That was busted. Better version:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d31edbcbfb5f64454aa419c6bb5dd568ac2603d1

Comment 17

[Jeff Muizelaar [:jrmuizel]]

So splitting this patch up is going to be a bit of pain. So I'll post highlights for review.

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Splitting out by file path should be pretty easy, at least:
Part 1 - changes to gfx/webrender and gfx/webrender_traits
Part 2 - changes to third_party/rust and toolkit/**/Cargo.lock
Part 3 - everything else (which will need proper review)

Comment 19

[Jeff Muizelaar [:jrmuizel]]

Attachment: Disable WrScrollFrameStackingContextGenerator stuff

We can probably remove this in a follow up.

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8837177 [details] [diff] [review]
Disable WrScrollFrameStackingContextGenerator stuff

This shows nothing in splinter but the diff looks ok. I'll file a follow-up for cleaning this up.

Comment 21

[Jeff Muizelaar [:jrmuizel]]

Attachment: The webrender changes

Comment 22

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8837185 [details] [diff] [review]
The webrender changes

Review of attachment 8837185 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure your commit messages are clean (e.g. no try push syntax)

Comment 23

[Jeff Muizelaar [:jrmuizel]]

Attachment: third_party changes

Comment 24

[Jeff Muizelaar [:jrmuizel]]

Attachment: toolkit changes

Nothing very interesting here. Just version updates.

Comment 25

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8837234 [details] [diff] [review]
third_party changes

Review of attachment 8837234 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming this is lifted straight from my rebased patch. I had to do some fiddling to make sure we didn't unnecessarily rev versions of libraries that are used by stylo.

Comment 26

[Jeff Muizelaar [:jrmuizel]]

Attachment: Layers and bindings changes

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/9cbd7126db64
Update webrender to 3c05fd2fccc2b51ec8b1b12cb96b7d011468766c. r=kats
https://hg.mozilla.org/projects/graphics/rev/47611a305c44
Update vendored rust libraries for webrender update. r=kats
https://hg.mozilla.org/projects/graphics/rev/ca2b6dc909b3
Disable now-incorrect WrScrollFrameStackingContextGenerator code. r=kats
https://hg.mozilla.org/projects/graphics/rev/5b1a780d4aa9
Update WR layers and FFI/bindings code for the webrender update. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/2dfcdea58f5d
Update reftest annotations for webrender. r=kats

Comment 28

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9cbd7126db64
https://hg.mozilla.org/mozilla-central/rev/47611a305c44
https://hg.mozilla.org/mozilla-central/rev/ca2b6dc909b3
https://hg.mozilla.org/mozilla-central/rev/5b1a780d4aa9
https://hg.mozilla.org/mozilla-central/rev/2dfcdea58f5d