Closed Bug 1335799 Opened 3 years ago Closed 3 years ago

Update to WebRender 0b6af19f3539937717a3f651a7357a6d09ded032 and sort out ffi types

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: nical, Assigned: nical)

References

Details

Attachments

(6 files, 3 obsolete files)

No description provided.
Assignee: nobody → nical.bugzilla
Duplicate of this bug: 1336454
Attachment #8834060 - Flags: review?(jmuizelaar)
Attached patch update ffi/bindings (obsolete) — Splinter Review
Attachment #8834061 - Flags: review?(jmuizelaar)
Summary: Update to WebRender 74ad1aa89a3ed2377191f9a21e2d2ea4dac063ff and sort out ffi types → Update to WebRender 7a63d0a224ec784c1caf8b08cdee9fbb0f6c35315 and sort out ffi types
Some of these failures look like blend mode problems.
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Some of these failures look like blend mode problems.

I'll look at these.
I believe this is causing the mix blend mode failures. The regresion is in the update range.

https://github.com/servo/webrender/issues/838
As Dzmitry pointed out, the clipping breakage is likely caused by https://github.com/servo/webrender/commit/303fa12f023fe163c5bbd2a01c78adfa09755ca1
The issue on github has been resolved and updating to a new WebRender (>512b4a1) should solve the mix-blend-mode issues.
Updating to a newer webrender should also get us better clipping support for scroll layers we will be needed going forward.
Summary: Update to WebRender 7a63d0a224ec784c1caf8b08cdee9fbb0f6c35315 and sort out ffi types → Update to WebRender 0b6af19f3539937717a3f651a7357a6d09ded032 and sort out ffi types
Note: this patch doesn't take into account the coordinate system change for clips.
Attachment #8834060 - Attachment is obsolete: true
Attachment #8834060 - Flags: review?(jmuizelaar)
Attachment #8834994 - Flags: review?(jmuizelaar)
Attachment #8834061 - Attachment is obsolete: true
Attachment #8834061 - Flags: review?(jmuizelaar)
Attachment #8834995 - Flags: review?(jmuizelaar)
Note that if I did the rebase correctly, the try push above should be green except for R4/Ru4 failures which will show UNEXPECTED-PASS on dom/canvas/test/reftest/1177726-text-stroke-bounds-ref.html. That is expected and will be fixed when 4b9e865bb255 merges from central to graphics, so ignore that failures.
So splitting this patch up is going to be a bit of pain. So I'll post highlights for review.
Splitting out by file path should be pretty easy, at least:
Part 1 - changes to gfx/webrender and gfx/webrender_traits
Part 2 - changes to third_party/rust and toolkit/**/Cargo.lock
Part 3 - everything else (which will need proper review)
We can probably remove this in a follow up.
Attachment #8837177 - Flags: review?(bugmail)
Comment on attachment 8837177 [details] [diff] [review]
Disable WrScrollFrameStackingContextGenerator stuff

This shows nothing in splinter but the diff looks ok. I'll file a follow-up for cleaning this up.
Attachment #8837177 - Flags: review?(bugmail) → review+
Attachment #8834994 - Attachment is obsolete: true
Attachment #8834994 - Flags: review?(jmuizelaar)
Attachment #8837185 - Flags: review?(bugmail)
Comment on attachment 8837185 [details] [diff] [review]
The webrender changes

Review of attachment 8837185 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure your commit messages are clean (e.g. no try push syntax)
Attachment #8837185 - Flags: review?(bugmail) → review+
Attachment #8837234 - Flags: review?(bugmail)
Attached patch toolkit changesSplinter Review
Nothing very interesting here. Just version updates.
Attachment #8837242 - Flags: review?(bugmail)
Comment on attachment 8837234 [details] [diff] [review]
third_party changes

Review of attachment 8837234 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming this is lifted straight from my rebased patch. I had to do some fiddling to make sure we didn't unnecessarily rev versions of libraries that are used by stylo.
Attachment #8837234 - Flags: review?(bugmail) → review+
Attachment #8837248 - Flags: review?(jmuizelaar)
Attachment #8837248 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/9cbd7126db64
Update webrender to 3c05fd2fccc2b51ec8b1b12cb96b7d011468766c. r=kats
https://hg.mozilla.org/projects/graphics/rev/47611a305c44
Update vendored rust libraries for webrender update. r=kats
https://hg.mozilla.org/projects/graphics/rev/ca2b6dc909b3
Disable now-incorrect WrScrollFrameStackingContextGenerator code. r=kats
https://hg.mozilla.org/projects/graphics/rev/5b1a780d4aa9
Update WR layers and FFI/bindings code for the webrender update. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/2dfcdea58f5d
Update reftest annotations for webrender. r=kats
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Attachment #8834995 - Flags: review?(jmuizelaar)
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.