Closed Bug 1335819 Opened 5 years ago Closed 1 year ago

Highlights algorithm: Use main image size

Categories

(Firefox for Android Graveyard :: Activity Stream, defect, P5)

All
Android
defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: sebastian, Unassigned)

References

Details

(Whiteboard: [MobileAS])

For ranking highlights the desktop add-on calculates the size of the main image:

> Math.min(image.width * image.height, 1e5)

Right now we only have the URL and do not know the size, so we use 0 for no image and 1 for image exists. Either store the size in our metadata JSON blob or access the stored image to determine the size (see bug 1301718).
Priority: -- → P2
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Iteration: --- → 1.15
Priority: P2 → P1
The tricky part about this is that we have never loaded that image in the first place: It usually comes from og:image or other metadata that is not loaded for displaying the website. The page-metadata-service from the desktop addon uses fastimage [1][2] to load a tiny bit of data to determine the image size.

[1] https://github.com/ShogunPanda/fastimage
[2] https://github.com/sdsykes/fastimage
Iteration: 1.15 → 1.16
Iteration: 1.16 → ---
Priority: P1 → P2
Assignee: s.kaspari → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3
Rank: 1
Rank: 1 → 2
All open Activity Stream bugs are moving from the whiteboard tag, "[mobileAS]", to the Firefox for Android component, "Activity Stream", so that I can keep better track of these bugs as the new triage owner; I will send out an email shortly with additional details, caveats, etc.
Component: General → Activity Stream
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.