Closed Bug 1335861 Opened 7 years ago Closed 7 years ago

add new tables to change notifier list

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

(Whiteboard: [lang=python])

Attachments

(1 file)

We've added a lot of new tables as part of the Multiple Signoffs project. Some of them should probably be added to the list of tables that respond to onInsert/Update/Change (https://github.com/mozilla/balrog/blob/b6511a720249f58f27edf09e0242e8b7501c7f8c/auslib/db.py#L2485).

At the very least:
* The Required Signoffs tables (both Product and Permissions), plus their Scheduled Changes versions
* The new Permissions Scheduled Changes table
* User Roles
* All of the Signoffs tables

We probably don't need to notify on changes to Releases' Scheduled Changes table, since we don't notify on changes to the Releases table itself (though I can see an argument for treating the SC table differently). I think we also don't need notifications on changes to the Scheduled Changes Conditions tables, since they are always modified in lock-step with their associated Scheduled Changes table.

We definitely don't need notification for the new history tables.
Priority: -- → P3
Assignee: nobody → bhearsum
Priority: P3 → P1
Attached file notify more!
Attachment #8893019 - Flags: review?(nthomas)
Attachment #8893019 - Flags: review?(nthomas) → review+
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/21355e3a19f7a389e23e9c873e9e218f95d0f2d2
bug 1335861: add notifications for most tables (#361). r=nthomas
Depends on: 1390197
This is in production.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: