Closed
Bug 1335862
Opened 7 years ago
Closed 7 years ago
Implement mayResolve for arguments objects
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.60 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
jQuery uses this pattern where they lookup 'nodeType' on everything you pass to it to check if it's a Node. Arguments objects are also used in such a way, but we don't attach property not found IC stubs, because arguments objects have a resolve function, but don't implement mayResolve. This should be an easy perf win.
Assignee | ||
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•7 years ago
|
||
I had a patch for this anyway, and I just saw this as an insignificant problem that showed up on Browsermark.
Updated•7 years ago
|
Attachment #8837215 -
Attachment is patch: true
Comment 2•7 years ago
|
||
Comment on attachment 8837215 [details] [diff] [review] Implement mayRresolve for arguments Review of attachment 8837215 [details] [diff] [review]: ----------------------------------------------------------------- Good find. ::: js/src/vm/ArgumentsObject.cpp @@ +436,5 @@ > + return true; > + > + JSAtom* atom = JSID_TO_ATOM(id); > + uint32_t index; > + if (atom->isIndex(&index)) obj_resolve actually only checks for JSID_IS_INT, probably because we don't support args length > JSID_INT_MAX/INT32_MAX.
Attachment #8837215 -
Flags: review?(jdemooij) → review+
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b9ee87240799 Implement mayResolve for arguments objects. r=jandem
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b9ee87240799
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•