Closed
Bug 1335898
Opened 8 years ago
Closed 8 years ago
convert SETA analyze_failures.py messages from logging.info to logging.warn
Categories
(Tree Management Graveyard :: Treeherder: SETA, defect)
Tree Management Graveyard
Treeherder: SETA
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: rwood)
References
Details
Attachments
(1 file)
in trying to decipher what is going on with SETA analyze_failures.py daily job, we are not seeing any indication in the log files, it appears that we have logging.info, instead of logging.warn- doing this should get us more data to see what is going on.
An example is here:
https://github.com/mozilla/treeherder/blob/ed8e39221da464af01dadc238886da077fe9f9ca/treeherder/seta/analyze_failures.py#L31
I would like to increase the logging for increase_jobs_priority() as well.
| Reporter | ||
Comment 1•8 years ago
|
||
not increase_jobs_priority, but adjust_jobs_priority:
https://github.com/mozilla/treeherder/blob/6d6f904317c86c776ff3fdfa4c2d085c003f38c9/treeherder/seta/models.py#L23
oh, possibly that needs to be fixed here to call the correct api?!?:
https://github.com/mozilla/treeherder/blob/ed8e39221da464af01dadc238886da077fe9f9ca/treeherder/seta/analyze_failures.py#L33
:rwood, can you do the PR here?
Flags: needinfo?(rwood)
| Assignee | ||
Comment 2•8 years ago
|
||
Sure!
Assignee: nobody → rwood
Status: NEW → ASSIGNED
Flags: needinfo?(rwood)
Comment 3•8 years ago
|
||
| Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8832977 [details] [review]
[treeherder] rwood-moz:bug1335898 > mozilla:master
The correct method (adjust_jobs_priority) is called in the latest master.
Attachment #8832977 -
Flags: review?(jmaher)
| Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8832977 [details] [review]
[treeherder] rwood-moz:bug1335898 > mozilla:master
thank you, this looks great
Attachment #8832977 -
Flags: review?(jmaher) → review+
Comment 6•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/345019b8010caf1a8aaac3527cd61af9653d8d4e
Bug 1335898 - Increase SETA logger level when changing job priority (#2126)
| Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Component: Treeherder → Treeherder: SETA
Updated•5 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•