Closed
Bug 1335939
Opened 7 years ago
Closed 7 years ago
Pref on ICE TCP
Categories
(Core :: WebRTC: Networking, defect, P1)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: drno, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832685 [details] Bug 1335939: pref on ICE TCP. https://reviewboard.mozilla.org/r/108884/#review110108 Looks good to me.
Attachment #8832685 -
Flags: review?(mfroman) → review+
Pushed by drno@ohlmeier.org: https://hg.mozilla.org/integration/autoland/rev/0592bfbbc9a4 pref on ICE TCP. r=mjf
|
||
Comment 4•7 years ago
|
||
Backed out for frequently failing test_presentation_datachannel_sessiontransport.html on Linux, especially with pgo: https://hg.mozilla.org/integration/autoland/rev/cace59edfadbd7acaeccedccc3966ca31e09fe92 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0592bfbbc9a41136079edbd1f079e6fa016eaa26 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=73833413&repo=autoland [task 2017-02-02T08:21:08.593883Z] 08:21:08 INFO - (ice/ERR) ICE(PC:1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s): peer (PC:1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s:default), stream(0-1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s aLevel=0) tried to trickle ICE in inappropriate state 4 [task 2017-02-02T08:21:08.594495Z] 08:21:08 INFO - [Socket Thread]: E/mtransport Trickle candidates are redundant for stream '0-1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s aLevel=0' because it is completed [task 2017-02-02T08:21:08.595159Z] 08:21:08 INFO - (ice/ERR) ICE(PC:1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s): peer (PC:1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s:default), stream(0-1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s aLevel=0) tried to trickle ICE in inappropriate state 4 [task 2017-02-02T08:21:08.595305Z] 08:21:08 INFO - [Socket Thread]: E/mtransport Trickle candidates are redundant for stream '0-1486023668357735 (id=18 url=chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_s aLevel=0' because it is completed [task 2017-02-02T08:21:08.595656Z] 08:21:08 INFO - [Main Thread]: D/DataChannel 7f6a52550280(7f6a52580740): OnChannelConnected - Dispatching [task 2017-02-02T08:21:08.596144Z] 08:21:08 INFO - [Main Thread]: D/DataChannel Init: origin = null [task 2017-02-02T08:21:08.596827Z] 08:21:08 INFO - JavaScript error: resource://gre/components/PresentationDataChannelSessionTransport.js, line 223: TypeError: this._window is null [task 2017-02-02T08:21:08.596888Z] 08:21:08 INFO - TEST-INFO | started process screentopng [task 2017-02-02T08:21:09.081986Z] 08:21:09 INFO - TEST-INFO | screentopng: exit 0 [task 2017-02-02T08:21:09.083145Z] 08:21:09 INFO - Buffered messages logged at 08:21:08 [task 2017-02-02T08:21:09.084681Z] 08:21:09 INFO - Client Transport is built. [task 2017-02-02T08:21:09.085363Z] 08:21:09 INFO - Client transport ready. [task 2017-02-02T08:21:09.086020Z] 08:21:09 INFO - Buffered messages finished [task 2017-02-02T08:21:09.091275Z] 08:21:09 INFO - TEST-UNEXPECTED-FAIL | dom/presentation/tests/mochitest/test_presentation_datachannel_sessiontransport.html | uncaught exception - NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "this._window is null" {file: "resource://gre/components/PresentationDataChannelSessionTransport.js" line: 223}]'[JavaScript Error: "this._window is null" {file: "resource://gre/components/PresentationDataChannelSessionTransport.js" line: 223}]' when calling method: [nsIPresentationDataChannelSessionTransportBuilder::onIceCandidate] at sendIceCandidate/<@chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_sessiontransport.html:142:20 [task 2017-02-02T08:21:09.092262Z] 08:21:09 INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:625:12 [task 2017-02-02T08:21:09.092396Z] 08:21:09 INFO - sendIceCandidate@chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_sessiontransport.html:142:5 [task 2017-02-02T08:21:09.092487Z] 08:21:09 INFO - buildDataChannelTransport/this._peerConnection.onicecandidate@resource://gre/components/PresentationDataChannelSessionTransport.js:77:7 [task 2017-02-02T08:21:09.093227Z] 08:21:09 INFO - dispatchEvent@resource://gre/components/PeerConnection.js:689:7 [task 2017-02-02T08:21:09.093388Z] 08:21:09 INFO - dispatchEvent@resource://gre/components/PeerConnection.js:1321:5 [task 2017-02-02T08:21:09.093900Z] 08:21:09 INFO - onIceCandidate@resource://gre/components/PeerConnection.js:1377:5 [task 2017-02-02T08:21:09.094501Z] 08:21:09 INFO - [task 2017-02-02T08:21:09.094702Z] 08:21:09 INFO - simpletestOnerror@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1583:11 [task 2017-02-02T08:21:09.095553Z] 08:21:09 INFO - OnErrorEventHandlerNonNull*@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1563:1 [task 2017-02-02T08:21:09.096422Z] 08:21:09 INFO - JavaScript error: chrome://mochitests/content/chrome/dom/presentation/tests/mochitest/test_presentation_datachannel_sessiontransport.html, line 142: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "this._window is null" {file: "resource://gre/components/PresentationDataChannelSessionTransport.js" line: 223}]'[JavaScript Error: "this._window is null" {file: "resource://gre/components/PresentationDataChannelSessionTransport.js" line: 223}]' when calling method: [nsIPresentationDataChannelSessionTransportBuilder::onIceCandidate]
Flags: needinfo?(drno)
|
Reporter | |
Comment 5•7 years ago
|
||
Awesome. I get exactly the same error when running the test locally on my machine just with straight mozilla-central. So I'm pretty sure this is not related to this patch. But I'll have a look what is going on here.
Flags: needinfo?(drno)
|
|
||
Comment 6•7 years ago
|
||
This started a week earlier, but frequency has gone through skyrocketed after this patch landed: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1268262&startday=2016-12-01&endday=2017-02-02&tree=all
| Comment hidden (mozreview-request) |
Pushed by drno@ohlmeier.org: https://hg.mozilla.org/integration/autoland/rev/3e26fd4bf489 pref on ICE TCP. r=mjf
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e26fd4bf489
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•