Closed Bug 1336024 Opened 6 years ago Closed 6 years ago

Split Image selection logic from ImageHost

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

patch - Split Image selection logic from ImageHost
46.75 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
It is a preparation for Bug 1336021.
Assignee: nobody → sotaro.ikeda.g
Component: Graphics: Layers → Graphics: WebRender
Attachment #8832808 - Flags: review?(nical.bugzilla)
Comment on attachment 8832808 [details] [diff] [review]
patch - Split Image selection logic from ImageHost

Review of attachment 8832808 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ImageCompositeTypes.h
@@ +11,5 @@
> +
> +namespace mozilla {
> +namespace layers {
> +
> +struct ImageCompositeNotificationInfo {

Is it worth adding a new file for this? How about placing this in CompositorTypes.h?
Attachment #8832808 - Flags: review?(nical.bugzilla) → review+
(In reply to Nicolas Silva [:nical] from comment #3)
> 
> Is it worth adding a new file for this? How about placing this in
> CompositorTypes.h?

Thanks for the comment. I am going to add ImageCompositeNotificationInfo to CompositorTypes.h.

My concern was adding the following to existing header file.
 > #include "base/process.h"
 > #include "mozilla/layers/LayersMessages.h"
CompositorTypes.h is included by IPC related headers. Then just adding '#include "mozilla/layers/LayersMessages.h"' to CompositorTypes.h caused build failures like the following. Then it seems better to keep attachment 8832808 [details] [diff] [review].

> error: ‘TextureFlags’ is not a member of ‘mozilla::layers’
Moved ImageCompositeNotificationInfo to CompositableHost.h
Attachment #8832808 - Attachment is obsolete: true
Attachment #8834282 - Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/a24574573128
Split Image selection logic from ImageHost r=nical
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.