1336024 - Split Image selection logic from ImageHost

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

It is a preparation for Bug 1336021.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Split Image selection logic from ImageHost

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b26c4d464e9d158737562cd4d79812177af952da

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8832808 [details] [diff] [review]
patch - Split Image selection logic from ImageHost

Review of attachment 8832808 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ImageCompositeTypes.h
@@ +11,5 @@
> +
> +namespace mozilla {
> +namespace layers {
> +
> +struct ImageCompositeNotificationInfo {

Is it worth adding a new file for this? How about placing this in CompositorTypes.h?

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Nicolas Silva [:nical] from comment #3)
> 
> Is it worth adding a new file for this? How about placing this in
> CompositorTypes.h?

Thanks for the comment. I am going to add ImageCompositeNotificationInfo to CompositorTypes.h.

My concern was adding the following to existing header file.
 > #include "base/process.h"
 > #include "mozilla/layers/LayersMessages.h"

Comment 5

[Sotaro Ikeda [:sotaro]]

CompositorTypes.h is included by IPC related headers. Then just adding '#include "mozilla/layers/LayersMessages.h"' to CompositorTypes.h caused build failures like the following. Then it seems better to keep attachment 8832808 [details] [diff] [review].

> error: ‘TextureFlags’ is not a member of ‘mozilla::layers’

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Split Image selection logic from ImageHost

Moved ImageCompositeNotificationInfo to CompositableHost.h

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/a24574573128
Split Image selection logic from ImageHost r=nical