Closed Bug 1336048 Opened 4 years ago Closed 4 years ago

Add display detection to dom/ipc/ContentChild.cpp

Categories

(Core :: IPC, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: stransky, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should use the same DISPLAY detection as we have in nsAppRunner.cpp.
Attachment #8832837 - Flags: review?(mh+mozilla)
Severity: minor → normal
Sorry for the drive by review, but I'm working on headless browsing and was curious if some of the wayland work would conflict. Instead of copying the detectDisplay code couldn't we just set an environment variable with the result of detectDisplay in the parent process and then just read that variable in the child?
Comment on attachment 8832837 [details]
Bug 1336048 - Add display detection to dom/ipc/ContentChild.cpp,

https://reviewboard.mozilla.org/r/109088/#review110502

Both this and nsAppRunner.cpp are in libxul. Just make the function in nsAppRunner.cpp non-static and use it.
Attachment #8832837 - Flags: review?(mh+mozilla)
(In reply to Brendan Dahl [:bdahl] from comment #2)
> Sorry for the drive by review, but I'm working on headless browsing and was
> curious if some of the wayland work would conflict. Instead of copying the
> detectDisplay code couldn't we just set an environment variable with the
> result of detectDisplay in the parent process and then just read that
> variable in the child?

I'd leave that for next iteration of this code. I think the shared detectDisplay() routine will work for now.
Comment on attachment 8832837 [details]
Bug 1336048 - Add display detection to dom/ipc/ContentChild.cpp,

https://reviewboard.mozilla.org/r/109088/#review111424

::: dom/ipc/ContentChild.cpp:530
(Diff revision 2)
>      char* argv[] = {
>        // argv0 is unused because g_set_prgname() was called in
>        // XRE_InitChildProcess().
>        nullptr,
>        option_name,
> -      display_name,
> +      (char *)display_name,

const_cast<char*>(display_name)
Attachment #8832837 - Flags: review?(mh+mozilla) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d482c6c4efb
Add display detection to dom/ipc/ContentChild.cpp, r=glandium
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8d482c6c4efb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.