Closed
Bug 1336066
Opened 8 years ago
Closed 8 years ago
'No screen' shows preview after clicking once on the device permission in the location bar
Categories
(Firefox :: Site Permissions, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | verified |
firefox54 | --- | verified |
People
(Reporter: pauly, Assigned: florian)
References
Details
(Keywords: regression, Whiteboard: [fxprivacy])
Attachments
(1 file)
5.29 KB,
patch
|
johannh
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
[Affected versions]: - 54 [Affected platforms]: - all [Steps to reproduce]: 1. Open https://mozilla.github.io/webrtc-landing/gum_test.html 2. Click the "Screen" button 3. From the dropdown select screen to preview 4. Click once the "screen share" permission in the location bar [Expected result]: - No change [Actual result]: - 'No screen' shows preview of the active screen [Regression range]: - tbd [Additional notes]: - Screencast: https://www.screencast.com/t/tXW6CuYWQI6G
Assignee | ||
Comment 1•8 years ago
|
||
Seems like an edge case of bug 1325223 that I didn't cover there.
Blocks: 1325223
Reporter | ||
Updated•8 years ago
|
Blocks: 1004061
status-firefox53:
--- → affected
Reporter | ||
Updated•8 years ago
|
Keywords: regression
Updated•8 years ago
|
Whiteboard: [fxprivacy][triage]
Updated•8 years ago
|
Assignee: nobody → florian
Priority: -- → P2
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8836090 -
Flags: review?(jhofmann)
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa44bf9c62e9
Comment 4•8 years ago
|
||
Comment on attachment 8836090 [details] [diff] [review] Patch Review of attachment 8836090 [details] [diff] [review]: ----------------------------------------------------------------- I haven't tried the patch locally but this looks pretty straightforward and has a test, so r=me ::: browser/base/content/test/popupNotifications/browser_popupNotification_5.js @@ +330,5 @@ > this.notification2.remove(); > this.notification3.remove(); > } > }, > + // Test clicking the anchor icon. Maybe you should mention the purpose of this test. :)
Attachment #8836090 -
Flags: review?(jhofmann) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbcec3916fc695fa52d0dab1a3e459cf46144a1e Bug 1336066 - avoid reshowing a persistent notification that has not been dismissed when clicking the anchor icon, r=johannh.
Updated•8 years ago
|
Iteration: --- → 54.2 - Feb 20
Updated•8 years ago
|
Flags: qe-verify?
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bbcec3916fc6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 7•8 years ago
|
||
Build ID: 20170214030231 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0 Verified as fixed on on Windows 10 x 64, Mac OS X 10.11 and Ubuntu 16.04 x64 on Firefox Nightly 54.0a1, Firefox Nightly 53.0a1 and Aurora 53.0a2.
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
Comment 8•8 years ago
|
||
Hani, how was this verified on 53 when this hasn't been uplifted to Aurora yet? That said, please request Aurora approval on this, Florian :)
Flags: needinfo?(hani.yacoub)
Flags: needinfo?(florian)
Comment 9•8 years ago
|
||
Sorry about that, I messed up the comments with another bug that I verified on Aurora too. I Verified this bug on Windows 10 x 64, Mac OS X 10.11 and Ubuntu 16.04 x64 on Firefox Nightly 54.0a1, as the flags indicates the version of Firefox which I tested. Thanks.
Flags: needinfo?(hani.yacoub)
Assignee | ||
Comment 10•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=417b1f06fda1
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8836090 [details] [diff] [review] Patch Approval Request Comment [Feature/Bug causing the regression]: bug 1004061 [User impact if declined]: possibly confusing state of permission prompt panels (and especially the screen sharing one with a preview) after clicking the anchor icon. Potential for leaking a video stream if there was an active screensharing preview at the time the anchor icon was clicked. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Not required but would be nice, steps are in comment 0. [List of other uplifts needed for the feature/fix]: none. [Is the change risky?]: Low. [Why is the change risky/not risky?]: One-line code change, and covered by automated test, which seem green on the try push from comment 10. [String changes made/needed]: none.
Flags: needinfo?(florian)
Attachment #8836090 -
Flags: approval-mozilla-aurora?
Comment 12•8 years ago
|
||
Comment on attachment 8836090 [details] [diff] [review] Patch Fix a screensharing regression and was verified. Aurora53+.
Attachment #8836090 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/ce2403f3f23b
Flags: in-testsuite+
Comment 14•8 years ago
|
||
Build ID: 20170221004019 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 Verified as fixed on Aurora 53.0a2 (20170221004019) on Windows 10 x 64, Mac OS X 10.10 and Ubuntu 16.04 x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•