1336068 - Autophone - unrooted device kills autophone startup

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

After I managed to bork nexus-5-7 on autophone-2, I found that when the autophone service attempted to start it would fail to register the device due to a lack of rooting and then kill autophone and prevent it from completing startup.

2017-02-01 17:47:25,130|1913|MainThread|console|INFO|Initializing device name=nexus-5-7, serialno=05f2b3164399e994
2017-02-01 17:47:27,754|1913|MainThread|adb|INFO|/system/bin/ls -a supported
2017-02-01 17:47:27,857|1913|MainThread|adb|INFO|Native cp support: True
2017-02-01 17:47:27,960|1913|MainThread|adb|INFO|Native chmod -R support: True
2017-02-01 17:47:28,063|1913|MainThread|adb|INFO|Setting SELinux Permissive Mode
2017-02-01 17:47:28,063|1913|MainThread|adb|WARNING|Unable to set SELinux Permissive due to Can not run command setenforce Permissive as root!.
2017-02-01 17:47:29,113|1913|MainThread|console|ERROR|Unable to create worker for device nexus-5-7 due to Can not run command ls -a /storage/sdcard0/tests/autophone/ as root!.
2017-02-01 17:47:29,164|1913|MainThread|console|INFO|Worker nexus-5-7 failed to register
2017-02-01 17:47:29,164|1913|MainThread|console|ERROR|Unable to initialize device nexus-5-7 due to 'S1S2Test' object has no attribute 'run_if_changed'.

Comment 1

[Bob Clary [:bc] (inactive)]

2017-02-02 21:10:13,792|15395|MainThread|console|INFO|Initializing device name=nexus-5-11, serialno=031aa93409317b38
2017-02-02 21:10:17,838|15395|MainThread|console|ERROR|Unable to create worker for device nexus-5-11 due to Can not run command ls -a /storage/sdcard0/tests/autophone/ as root!.
2017-02-02 21:10:18,904|15395|MainThread|console|INFO|Worker nexus-5-11 failed to register
2017-02-02 21:10:18,904|15395|MainThread|console|ERROR|Unable to initialize device nexus-5-11 due to 'S1S2Test' object has no attribute 'run_if_changed'.
Traceback (most recent call last):
  File "autophone.py", line 1534, in <module>
    main()
  File "autophone.py", line 1528, in main
    exit_code = autophone_runner(options)
  File "autophone.py", line 1231, in autophone_runner
    autophone = AutoPhone(loglevel, options)
  File "autophone.py", line 138, in __init__
    self.read_devices()
  File "autophone.py", line 816, in read_devices
    self.purge_worker(device_name)
  File "autophone.py", line 707, in purge_worker
    t.remove()
  File "/mozilla/projects/autophone/src/bclary-autophone/phonetest.py", line 309, in remove
    had_run_if_changed = PhoneTest.instances[key].run_if_changed
AttributeError: 'S1S2Test' object has no attribute 'run_if_changed'

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: bug-1336068-removal.patch

Works for me locally when setting SuperSu to automatically deny root.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8833165 [details] [diff] [review]
bug-1336068-removal.patch

Review of attachment 8833165 [details] [diff] [review]:
-----------------------------------------------------------------

all good!

Comment 4

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/6a5f52ea4dbfac9e60771821b663df18b1f135a3
deployed 2017-02-03 07:10