misleading indentation introduced in bug 1120441

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jcristau, Assigned: jcristau)

Tracking

Trunk
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox53 fixed, firefox54 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The body of the if () block should be moved one level deeper.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8832857 [details]
Bug 1336084 - fix indentation after bug 1120441

https://reviewboard.mozilla.org/r/109114/#review110330
Attachment #8832857 - Flags: review?(ahunt) → review+
Comment on attachment 8832857 [details]
Bug 1336084 - fix indentation after bug 1120441

Clearing r+ as per:
https://bugzilla.mozilla.org/show_bug.cgi?id=1120441#c25

This fix is good, but I want to completely remove the conditional in question since I didn't want to land it in the first place (I'll provide a new patch to do that).
Attachment #8832857 - Flags: review+
Comment hidden (mozreview-request)
status-firefox52: --- → unaffected
status-firefox53: --- → affected

Comment 6

2 years ago
mozreview-review
Comment on attachment 8832984 [details]
Bug 1336084 - Remove unneeded isForegrounded() call

https://reviewboard.mozilla.org/r/109220/#review111510
Attachment #8832984 - Flags: review?(s.kaspari) → review+

Comment 7

2 years ago
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbfba62842ac
Remove unneeded isForegrounded() call r=sebastian

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fbfba62842ac
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8832984 [details]
Bug 1336084 - Remove unneeded isForegrounded() call

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1120441.

[User impact if declined]: High probability of no user impact. However the code we are removing hasn't been tested extensively on nightly, and should therefore be removed to avoid unexpected issues.

[Is this code covered by automated tests?]: No.

[Has the fix been verified in Nightly?]: No.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: Low risk.

[Why is the change risky/not risky?]: This patch removes an unnecessary conditional. Nightly and beta both reflect the state after this patch (the unnecessary condition only landed on central, the patch that was uplifted to beta was fixed and doesn't contain the conditional, but aurora had the original patch uplifted directly from central).

[String changes made/needed]:None.
Attachment #8832984 - Flags: approval-mozilla-aurora?
Attachment #8832984 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8832984 [details]
Bug 1336084 - Remove unneeded isForegrounded() call

In order to align with beta, take this in aurora. Aurora53+.

Comment 11

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/eabe078e6170
status-firefox53: affected → fixed
You need to log in before you can comment on or make changes to this bug.