1336098 - When the input is silent, AnalyserNode.getFloatFrequencyData should put -Infinity in the buffer

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Paul Adenot (:padenot)]

This has changed at some point in the spec, and we haven't done the change.

Comment 1

[Paul Adenot (:padenot)]

Attachment: fix it and add a test

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8832876 [details] [diff] [review]
fix it and add a test

Review of attachment 8832876 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/webaudio/test/test_analyserNodeMinimum.html
@@ +30,5 @@
> +  sp.onaudioprocess = function() {
> +    analyser.getFloatFrequencyData(buf);
> +    var correct = true;
> +    for (var i = 0; i < buf.length; i++) {
> +     correct |= buf[i] == -Infinity;

This should be &=.

@@ +33,5 @@
> +    for (var i = 0; i < buf.length; i++) {
> +     correct |= buf[i] == -Infinity;
> +    }
> +    ok(correct, "silent input process -Infinity in decibel bins");
> +    if(iteration_count--) {

And this should be negated.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02e6983ec02a
When the input is silent, AnalyserNode.getFloatFrequencyData should put -Infinity in the buffer. r=pehrsons

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/02e6983ec02a

Comment 5

[Eric Shepherd [:sheppy]]

Updated documentation:

https://developer.mozilla.org/en-US/docs/Web/API/AnalyserNode/getFloatFrequencyData

https://developer.mozilla.org/en-US/Firefox/Releases/54