1336229 - Crash in IdleRequestExecutorTimeoutHandler::Call

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This bug was filed from the Socorro interface and is 
report bp-d8f9e9ff-dadc-4c31-a4ab-8318d2170202.
=============================================================

I seem to hit this content process crash when navigating forward / backward in certain tabs with the 2017-02-02 Nightly.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Given the timing and location of the crash, it looks like this could related to changes in bug 1313864.

:farre, what do you think?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I hit this crash again trying to load the related source file:

https://hg.mozilla.org/mozilla-central/annotate/f985243bb630/dom/base/nsGlobalWindow.cpp#l613

Not sure if other steps are needed to trigger the crash.  At this point, I am hitting it every minute or so in this session when loading new things (but there were hours of problem free usage earlier in the day).

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

I hit bug 1336242 when navigating, and the code we're crashing in seems somewhat similar, so maybe it is related.

Comment 4

[Andreas Farre [:farre]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> Given the timing and location of the crash, it looks like this could related
> to changes in bug 1313864.
> 
> :farre, what do you think?

Yep, seems very likely. Is it bad, or do I have time to try to get a fix in?

Comment 5

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1336229-Don-t-dispatch-canceled-IdleRequestExecu.patch

I haven't been able to reproduce the crash, but I think I understand how it happens and this should be the fix for it.

Comment 7

[Andreas Farre [:farre]]

Waiting on https://treeherder.mozilla.org/#/jobs?repo=try&revision=a95469e7dd328a77aab117e32731fb8641da0653

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42d594b85056
Don't dispatch canceled IdleRequestExecutors. r=bkelly

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/42d594b85056