Closed Bug 1336229 Opened 7 years ago Closed 7 years ago

Crash in IdleRequestExecutorTimeoutHandler::Call

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed

People

(Reporter: jryans, Assigned: farre)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

0001-Bug-1336229-Don-t-dispatch-canceled-IdleRequestExecu.patch
1.13 KB, patch
bkelly
: review+
Details | Diff | Splinter Review 
This bug was filed from the Socorro interface and is 
report bp-d8f9e9ff-dadc-4c31-a4ab-8318d2170202.
=============================================================

I seem to hit this content process crash when navigating forward / backward in certain tabs with the 2017-02-02 Nightly.
Given the timing and location of the crash, it looks like this could related to changes in bug 1313864.

:farre, what do you think?
Blocks: 1313864
Flags: needinfo?(afarre)
I hit this crash again trying to load the related source file:

https://hg.mozilla.org/mozilla-central/annotate/f985243bb630/dom/base/nsGlobalWindow.cpp#l613

Not sure if other steps are needed to trigger the crash.  At this point, I am hitting it every minute or so in this session when loading new things (but there were hours of problem free usage earlier in the day).
I hit bug 1336242 when navigating, and the code we're crashing in seems somewhat similar, so maybe it is related.
See Also: → 1336242
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> Given the timing and location of the crash, it looks like this could related
> to changes in bug 1313864.
> 
> :farre, what do you think?

Yep, seems very likely. Is it bad, or do I have time to try to get a fix in?
Flags: needinfo?(afarre)
I haven't been able to reproduce the crash, but I think I understand how it happens and this should be the fix for it.
Assignee: nobody → afarre
Attachment #8833245 - Flags: review?(bkelly)
Attachment #8833245 - Flags: review?(bkelly) → review+
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42d594b85056
Don't dispatch canceled IdleRequestExecutors. r=bkelly
https://hg.mozilla.org/mozilla-central/rev/42d594b85056
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
See Also: → 1368335
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: