1336326 - A few more small profiler improvements

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Nicholas Nethercote [inactive]]

Here's a motley collection of small improvements.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove Sampler::GetRegisteredThreads()

Sampler::sRegisteredThreadsMutex is public. Might as well make
Sampler::sRegisteredThreads public too. This allows the getter to be removed,
and makes the code a little easier to read.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Make sRegisteredThreadsMutex a StaticMutex

StaticMutexes don't need to be created or destroyed, which avoids the need for
checking if they still exist.

This patch also adds locking to a few functions that lacked it. Every access to
sRegisteredThreads is now protected appropriately.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove SamplerRegistry

We only have one global Sampler, gSampler, and so SamplerRegistry is just an
unnecessary and obfuscating wrapper around it.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfcd7fa37af1a07dbe2d221735bcb192ad4c43e7
Bug 1336326 (part 1) - Remove Sampler::GetRegisteredThreads(). r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/32550b42266999359049ab671fce22fdb5dc4f7b
Bug 1336326 (part 2) - Make sRegisteredThreadsMutex a StaticMutex. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/65c5923d0feccdbe87b3dfc50a389e715d775a70
Bug 1336326 (part 3) - Remove SamplerRegistry. r=mstange.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dfcd7fa37af1
https://hg.mozilla.org/mozilla-central/rev/32550b422669
https://hg.mozilla.org/mozilla-central/rev/65c5923d0fec