A few more small profiler improvements

RESOLVED FIXED in Firefox 54

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

2 years ago
Here's a motley collection of small improvements.
Assignee

Updated

2 years ago
Component: Profiler → Gecko Profiler
Product: Tamarin → Core
Assignee

Updated

2 years ago
Assignee

Comment 1

2 years ago
Sampler::sRegisteredThreadsMutex is public. Might as well make
Sampler::sRegisteredThreads public too. This allows the getter to be removed,
and makes the code a little easier to read.
Attachment #8833167 - Flags: review?(mstange)
Assignee

Updated

2 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Assignee

Comment 2

2 years ago
StaticMutexes don't need to be created or destroyed, which avoids the need for
checking if they still exist.

This patch also adds locking to a few functions that lacked it. Every access to
sRegisteredThreads is now protected appropriately.
Attachment #8833168 - Flags: review?(mstange)
Assignee

Comment 3

2 years ago
We only have one global Sampler, gSampler, and so SamplerRegistry is just an
unnecessary and obfuscating wrapper around it.
Attachment #8833169 - Flags: review?(mstange)
Attachment #8833167 - Flags: review?(mstange) → review+
Attachment #8833168 - Flags: review?(mstange) → review+
Attachment #8833169 - Flags: review?(mstange) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dfcd7fa37af1
https://hg.mozilla.org/mozilla-central/rev/32550b422669
https://hg.mozilla.org/mozilla-central/rev/65c5923d0fec
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.