Closed
Bug 1336378
Opened 7 years ago
Closed 7 years ago
Remove toolbar-view.js
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox54 verified)
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | verified |
People
(Reporter: rickychien, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Whiteboard: [netmonitor])
Attachments
(1 file)
Architecture reactify step for creating top level NetworkMonitor react component. * Remove toolbar-view.js and import Toolbar react component directly. * Clean up toolbar as well as relevant components
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833255 [details] Bug 1336378 - Remove toolbar-view.js https://reviewboard.mozilla.org/r/109496/#review110590 I like the patch and the direction it's going! Two questions: * Shouldn't the implementation of NetworkDetailsPanel be part of bug 1317645 ? * The ToolbarClearButton component does almost nothing, shouldn't we just define the button using 'button' component in the toolbar directly? Honza
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] from comment #2) > Two questions: > > * Shouldn't the implementation of NetworkDetailsPanel be part of bug 1317645? Ah, it was added accidentally. I will remove it. > * The ToolbarClearButton component does almost nothing, shouldn't we just > define the button using 'button' component in the toolbar directly? Make sense. I'd like to define all of these buttons in toolbar.js
| Comment hidden (mozreview-request) |
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833255 [details] Bug 1336378 - Remove toolbar-view.js https://reviewboard.mozilla.org/r/109496/#review110628 Yes, this is a lot better! R+ assuming try is green. Honza
Attachment #8833255 -
Flags: review?(odvarko) → review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a103a60cba8 Remove toolbar-view.js r=Honza
|
||
Updated•7 years ago
|
Iteration: --- → 54.1 - Feb 6
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [netmonitor][triage] → [netmonitor]
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3a103a60cba8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
|
|
||
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: ciprian.georgiu
|
||
Comment 8•7 years ago
|
||
This bug is verified fixed on latest Nightly 54.0a1 (2017-02-08) under Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64 LTS.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•