1336400 - Remove HTMLMediaElement::mozAutoplayEnabled

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1336400 - part1 : remove MozAutoplayEnabled from videocontrols.xml.

Review commit: https://reviewboard.mozilla.org/r/199060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199060/

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1336400 - part2 : remove MozAutoplayEnabled attribute from HTMLMediaElement.

Review commit: https://reviewboard.mozilla.org/r/199062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199062/

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1336400 - part3 : move all autoplay checks to CanActivateAutoplay().

1. move all checks to CanActivateAutoplay()
2. don't cache the pref's value in advance, it might cause wrong result
   if user changes pref after media was binded to tree.

Review commit: https://reviewboard.mozilla.org/r/199078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199078/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8927784 [details]
Bug 1336400 - part2 : remove MozAutoplayEnabled attribute from HTMLMediaElement.

https://reviewboard.mozilla.org/r/199062/#review204142

::: dom/webidl/HTMLMediaElement.webidl:115
(Diff revision 1)
>    [Pref="media.test.dumpDebugInfo"]
>    void mozDumpDebugInfo();
>  
>    attribute MediaStream? srcObject;
>  
>    attribute boolean mozPreservesPitch;

Not about this bug, but do we have a bug to remove also mozPreservesPitch

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8927783 [details]
Bug 1336400 - part1 : remove MozAutoplayEnabled from videocontrols.xml.

https://reviewboard.mozilla.org/r/199060/#review204274

Comment 6

[Alastor Wu [:alwu]]

(In reply to Olli Pettay [:smaug] from comment #4)
> Not about this bug, but do we have a bug to remove also mozPreservesPitch

Yes, bug1336399.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8927785 [details]
Bug 1336400 - part3 : move all autoplay checks to CanActivateAutoplay().

https://reviewboard.mozilla.org/r/199078/#review204332

Comment 8

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb592ec4022b9dd4a2eeb801e919df1332c13247&selectedJob=144270390

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40241a2e3c1d
part1 : remove MozAutoplayEnabled from videocontrols.xml. r=jaws
https://hg.mozilla.org/integration/autoland/rev/a76b925084ea
part2 : remove MozAutoplayEnabled attribute from HTMLMediaElement. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a4810cd2202e
part3 : move all autoplay checks to CanActivateAutoplay(). r=jwwang

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/40241a2e3c1d
https://hg.mozilla.org/mozilla-central/rev/a76b925084ea
https://hg.mozilla.org/mozilla-central/rev/a4810cd2202e

Comment 11

[Kohei Yoshino [:kohei]]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/htmlmediaelement-mozautoplayenabled-has-been-removed/

Comment 12

[Eric Shepherd [:sheppy]]

Not documented on MDN; however, the change is now mentioned briefly on Firefox 59 for developers.