Closed Bug 1336434 Opened 4 years ago Closed 3 years ago
"Your Top Sites" should say "Top Sites" when we're using the default set
59 bytes, text/x-review-board-request
1.96 KB, patch
|Details | Diff | Splinter Review|
Per the qx meeting notes: * question for verdi: should the heading read "Top Sites" initially when there are no history tiles? --> Yes - no history or default sites it should say "Top Sites" and when your stuff is imported it should say "Your top sites"
I am working on this.
I've changed the string in the newTab.dtd file from "Show your top sites" to "Your top sites". Is this all?
I've changed the string in the newTab.dtd file from "Show your top sites" to "Top sites". Is this all ?
If we can just replace "your top sites" with "top sites", it should be a more generic solution to this.
Hi Anjul, I'm afraid this isn't a mentored bug, and also isn't the easiest to work on. It's related to a new feature that is not enabled by default. Perhaps take a look at https://www.joshmatthews.net/bugsahoy/?ff=1&unowned=1 to see if there are other bugs there that you'd be interested in working on?
Comment on attachment 8837108 [details] Bug 1336434 - "Your Top Sites" heading should say "Top Sites" instead when using the default set. https://reviewboard.mozilla.org/r/112348/#review113646 Tests for this might be a good idea?
Attachment #8837108 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d65e47dee9a4 "Your Top Sites" heading should say "Top Sites" instead when using the default set. r=Gijs
(In reply to :Gijs from comment #7) > Comment on attachment 8837108 [details] > Bug 1336434 - "Your Top Sites" heading should say "Top Sites" instead when > using the default set. > > https://reviewboard.mozilla.org/r/112348/#review113646 > > Tests for this might be a good idea? I'd rather not bake en-US specifics into tests. Also, given the plan to have Activity Stream code replace this implementation, it seems that this won't ever ship to end users beyond a funnelcake.
Approval Request Comment [Feature/Bug causing the regression]: bug 1334444 / bug 1332318 [User impact if declined]: see comment 0 [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: / [Is the change risky?]: no [Why is the change risky/not risky?]: it's limited to browser.newtabpage.compact = true (not the default) [String changes made/needed]: string hardcoded for the funnelcake, no l10n needed
see previous comment
Comment on attachment 8837717 [details] [diff] [review] patch for uplift about:newtab changes for funnelcake, aurora53+, beta52+
I have reproduced this according to Firefox nightly (2017-02-03) Fixing bug is verified on Latest Developer Edition, Latest Beta , Latest Nightly -- Build ID:(20170303004003), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:53.0) Gecko/20100101 Firefox/53.0 -- Build ID:(20170307064827),User Agent:Mozilla/5.0 (Windows NT 10.0; rv:53.0) Gecko/20100101 Firefox/53.0 -- Build ID:(20170308030207), User Agent:Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0 Tested OS-- Windows10 32bit [bugday-20170308]
You need to log in before you can comment on or make changes to this bug.