Closed
Bug 1336479
Opened 4 years ago
Closed 4 years ago
Get QR builds for 32-bit desktop platforms
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(3 files)
Right now our desktop QR builds are all 64-bit, because it was easier. IIRC there were some issues with 32-bit builds. We'll need to hammer those out in order to get QR builds to tier-1 status or to have --enable-webrender the default.
Assignee | ||
Comment 1•4 years ago
|
||
I did a try push with a 32-bit linux build and it failed with this: [task 2017-02-06T22:03:18.547663Z] 22:03:18 INFO - error: failed to run custom build command for `x11 v2.12.1` [task 2017-02-06T22:03:18.547967Z] 22:03:18 INFO - process didn't exit successfully: `/home/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/rust/./release/build/x11-f0209bff941bc17f/build-script-build` (exit code: 101) [task 2017-02-06T22:03:18.548120Z] 22:03:18 INFO - --- stderr [task 2017-02-06T22:03:18.548421Z] 22:03:18 INFO - thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(PkgConfig(CrossCompilation), State { next_error: None })', ../src/libcore/result.rs:837 [task 2017-02-06T22:03:18.548762Z] 22:03:18 INFO - note: Run with `RUST_BACKTRACE=1` for a backtrace. [task 2017-02-06T22:03:18.549810Z] 22:03:18 INFO - /home/worker/workspace/build/src/config/rules.mk:975: recipe for target 'force-cargo-library-build' failed the x11 crate is pulled in by offscreen_gl_context, so if we ditch that (which IIRC sotaro was planning on doing, by making the webrender->offscreen_gl_context dependency optional) then this problem goes away.
Assignee | ||
Comment 2•4 years ago
|
||
I was able to do a successful 32-bit build on windows locally. I used the "stable-i686-pc-windows-msvc" rust toolchain (set it to the default toolchain via rustup) and the 32-bit mozillabuild shell. mozconfig was simple: mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-win32-wr mk_add_options AUTOCLOBBER=1 ac_add_options --enable-webrender I'll see if I can get it going in automation as well.
Assignee | ||
Comment 3•4 years ago
|
||
Going back to linux - I wasn't able to figure out how to do a 32-bit linux build on my 64-bit machine, but I used a 1-click loaner to discover that I can reproduce the x11 build failure like so: - make sure the rustup toolchain is stable-x86_64-unknown-linux-gnu and the i686-unknown-linux-gnu target is installed - do a fresh clone of the webrender standalone repo - in webrender/webrender do `cargo build --target=i686-unknown-linux-gnu` This basically cross-compiles webrender from a 64-bit host to a 32-bit target, and x11 (or more specifically pkgconfig) doesn't like that. I'll see if I can find a good fix.
Assignee | ||
Comment 4•4 years ago
|
||
Adding PKG_CONFIG_ALLOW_CROSS=1 to the environment seems like the right fix. Try push for windows and linux 32-bit builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ee483b47827659642a0635672eea06513cf74e6 https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ce17408000e30d66899666d89df06a239fe380d
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → bugmail
Assignee | ||
Comment 7•4 years ago
|
||
Note that I'm only enabling these builds on the graphics branch.
Comment 8•4 years ago
|
||
mozreview-review |
Comment on attachment 8835055 [details] Bug 1336479 - Add 32-bit windows QR builds. https://reviewboard.mozilla.org/r/110748/#review112134
Attachment #8835055 -
Flags: review?(kmoir) → review+
Comment 9•4 years ago
|
||
mozreview-review |
Comment on attachment 8835054 [details] Bug 1336479 - Add 32-bit linux QR builds. https://reviewboard.mozilla.org/r/110746/#review112136
Attachment #8835054 -
Flags: review?(kmoir) → review+
Comment 10•4 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f92f4ebcd71 Add 32-bit linux QR builds. r=kmoir https://hg.mozilla.org/integration/autoland/rev/4109dedc3653 Add 32-bit windows QR builds. r=kmoir
Assignee | ||
Updated•4 years ago
|
See Also: → https://github.com/mozilla/treeherder/pull/2146
Comment 11•4 years ago
|
||
Updated•4 years ago
|
Attachment #8835110 -
Flags: review+
Comment 12•4 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/891b6a65c42787e0acb501bca567c0cf77ae1783 Bug 1336479 - Add descriptive names for the 32-bit QR builds (#2146)
Comment 13•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f92f4ebcd71 https://hg.mozilla.org/mozilla-central/rev/4109dedc3653
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•