1336591 - [PDF Viewer] Canvas transparency broken with HWA enabled

Status: VERIFIED FIXED

(Core :: Graphics, defect, P3)

Description

[Jonas Jenwald [:Snuffleupagus]]

Attachment: issue8022.pdf

Steps to reproduce:
Open the attached PDF file in Firefox.

Result:
Part of the canvas has incorrect transparency, please see the attached screen-shot. Disabling HWA fixes the problem.

Regression range (it unfortunately seems that this regressed in *two* steps):
1. https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ca5142203259cd252723d34e75d3e3b799b21765&tochange=538d248fa252a4100082fd9bc3fdc08d322cda22

Bas Schouten — Bug 1258168: Push ClearType compatible clipping layers when the last pushed layer was marked as opaque. r=jrmuizel

2. https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4f54551cf526994ec2749bb3f39623369c423d2f&tochange=5a793218e7abe53a07a656fe0b9f330d5fc0f83f

Bas Schouten — Bug 1303534: Make sure to pop all clips before grappig the image for the top-level 'layer'. r=jrmuizel

Comment 1

[Jonas Jenwald [:Snuffleupagus]]

Attachment: issue8022.png

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Doesn't seem likely this will get fixed for the 53 time frame, but if we come up with a fix, please request uplift as far as you think it's reasonable.

Comment 3

[Gerry Chang [:gchang]]

Mark 54 fix-optional as there are no actions for the moment but still happy to have the fix in 54.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I don't feel the need to track this for 55. If a fix is ready and deemed low risk, please nominate for uplift to Beta55.

Comment 5

[Lee Salzman [:lsalzman]]

Fixed by bug 1642583

Comment 6

[Jonas Jenwald [:Snuffleupagus]]

Attachment: bug.png

This is much better now, thank you!
However, it's still not completely fixed as shown in the attached screen-shot (with a red arrow added to highlight the bug).

Comment 7

[Lee Salzman [:lsalzman]]

Attachment: Bug 1336591 - Push clips when applying D2D gradients. r?jrmuizel

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae34b453317a
Push clips when applying D2D gradients. r=gfx-reviewers,aosmond

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ae34b453317a

Comment 10

[Lee Salzman [:lsalzman]]

Comment on attachment 9253737 [details]
Bug 1336591 - Push clips when applying D2D gradients. r?jrmuizel

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Visual artifacts in PDF.js (and all Canvas2D) on Windows.
• User impact if declined: Primitives in PDF.js (and all Canvas2D) don't clip properly on Windows leading to significant visual artifacting.
• Fix Landed on Version: 96
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively small change that essentially just undoes an ancient regressing bug.
• String or UUID changes made by this patch:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9253737 [details]
Bug 1336591 - Push clips when applying D2D gradients. r?jrmuizel

Approved for 91.5esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/257b6f3fe407

Comment 13

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue on Win 10 x64 on two affected Nightly builds: 2017-02-03 and 2021-12-03.
Verified fixed with 91.5.0esr (20220105212146) and 96.0 (20220103221059) on Win 10 x64.