1336603 - Move PCCounts state from ZoneGroup back to the runtime

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

Bug 1325050 moved the PCCounts state (|profilingScripts|, |scriptAndCountsVector|) from JSRuntime to ZoneGroup.  While this is nice for guaranteeing a preemptively scheduled thread exclusive access to this state, it isn't really compatible with the PCCounts API, which expects exclusive access to the entire runtime and wants counts in the form of a single runtime wide vector.  Rather than reworking this API, it seems simpler to just go back to having the state on the runtime for now, since there isn't a problem with synchronization here in a cooperatively scheduled runtime.

Most of this patch is backing out pieces of bug 1325050.  Sorry about the churn.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8833513 [details] [diff] [review]
patch

Review of attachment 8833513 [details] [diff] [review]:
-----------------------------------------------------------------

When we move to running JS concurrently, will the ProtectedData asserts catch problems here?

Comment 2

[Brian Hackett [Laid off!]]

(In reply to Jan de Mooij [:jandem] from comment #1)
> Comment on attachment 8833513 [details] [diff] [review]
> patch
> 
> Review of attachment 8833513 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> When we move to running JS concurrently, will the ProtectedData asserts
> catch problems here?

Yes, before we can have preemptive multithreading we'll need to remove ActiveThreadData and all other stuff that depends on having an active thread on the runtime, replacing the synchronization methods on these fields with something that behaves correctly with concurrently running JS.

Comment 3

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/392e110a97692b0834ecd3f2c709e72dba0cd4d0

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/392e110a9769