1336631 - Import window prompt appears on Funnelcake v99 build upon opening

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[u554753]

User Agent: 
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

Steps to Reproduce:

1. Clear any Mozilla data on file system through %APPDATA% 
2. Download Funnelcake 99 build at https://download.mozilla.org/?product=firefox-stub-f99&os=win&lang=en-US
3. Go through the installation process

Expected Result:

Auto Import from default browser - including bookmarks/history/etc.

Actual Result: 

Import prompt is displayed upon opening.

Reference Video:

https://gwimberly-softvision.tinytake.com/sf/MTMxNjA2N180ODcxMzcz

Comment 1

[u554753]

Note this only occurs on Windows 10, not Windows 7 or 8.1.

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Does the browser come up showing the proper https://www.mozilla.org/en-US/firefox/51.0.1/firstrun/?f=99 ? I'm wondering if somehow the stub is downloading the wrong full installer.

I haven't been able to reproduce this scenario yet on Windows 10 with a clean system, it may be that something left over in the registry from a previous install is affecting this (if only %APPDATA%/Mozilla is being cleared)?

Comment 3

[u554753]

Hi Adam,

We clear everything in %APPDATA%. Is there any other procedures we should take?

Comment 4

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

I'm not sure what else should be cleared, I was just trying to figure out why I haven't seen it yet.

1. Just to be clear, when Firefox appears after the import, does it show firstrun/?f=99 ? I want to rule out the stub somehow installing the wrong version.

2. You could check whether the automigration failed. If I'm reading this [1] right, it should show the dialog if automigration fails. There might be something about your Chrome profile (which seems to be the default) that is tripping up the migration. Though if you've been testing automigration before with the same setup, this doesn't seem like it would be the issue.

There should be telemetry recorded about the automigration [2]. Immediately after installation:

2a. go to about:telemetry
2b. toggle on the Histograms section
2c. put FX_STARTUP_MIGRATION_AUTOMATED_IMPORT_PROCESS_SUCCESS in the Filter box (or just look for it)
2d. There's a Copy button if you mouse over the histogram, copy that and paste the result here
2e. If it shows 0 sample you can try selecting the "Archived ping data" radio button under "Ping data source" at the top of the page

I was able to cause the import box to show up by creating a second Chrome profile ("Add person" in Settings), with the following histogram:
> FX_STARTUP_MIGRATION_AUTOMATED_IMPORT_PROCESS_SUCCESS
> 2 samples, average = 2.5, sum = 5
> 
> 0 |#########################  1  50%
> 5 |#########################  1  50%
> 6 |  0  0%

which makes sense as it would die here [3] in pickProfile, before 10 would be added [4].

This seems to be the intended behavior, so if your telemetry indicates the automigrate failed then that's the cause. If that's the case, you could set the default browser to Edge or IE before the install, those profiles might be simple enough for the automigrate to succeed.

3. I don't know much sabout the automigration stuff, I'm setting ni? to Gijs to get his take on it.

[1] https://hg.mozilla.org/releases/mozilla-release/file/FIREFOX_51_0_1_RELEASE/browser/components/migration/MigrationUtils.jsm#l917
[2] https://hg.mozilla.org/releases/mozilla-release/file/FIREFOX_51_0_1_RELEASE/browser/components/migration/AutoMigrate.jsm#l82
[3] https://hg.mozilla.org/releases/mozilla-release/file/FIREFOX_51_0_1_RELEASE/browser/components/migration/AutoMigrate.jsm#l173
[4] https://hg.mozilla.org/releases/mozilla-release/file/FIREFOX_51_0_1_RELEASE/browser/components/migration/AutoMigrate.jsm#l89

Comment 5

[:Gijs (he/him)]

I think Adam's advice on how to gain more info here is good. The only other thing I would say is that I would expect messages to show up in the browser console if automigration fails and we fall back to manual migration, on that first run of Firefox (which should give an indication of what went wrong). The final thing you could do is check that the preference "browser.migrate.automigrate.enabled" is set to true when you open about:config.

I'll note that the screencast seems to indicate there's an icon on the desktop for Firefox before the installer finishes running, which suggests there was an existing Firefox install. Have you verified the distribution folder is correctly placed into the Firefox install dir when installing? I guess in theory it's also possible there's a bug in the pave-over install path and the prefs aren't installed correctly - but then I would expect other things, besides the automigration, would also not work as expected.

Comment 6

[u554753]

I tried this with another computer running native Windows 10 and was unable to replicate this issue. 

I'll try again with the computer I reported this bug on with the suggestions given in Comment 4 and 5. Thanks.

Comment 7

[u554753]

On the computer I've reported this bug on, this problem is still reoccuring.

Per Comment 2 - On 99 build, the first link that appears is indeed https://www.mozilla.org/en-US/firefox/51.0.1/firstrun/?f=99

Per Comment 4 - Here is the result of the telemetry data

FX_STARTUP_MIGRATION_AUTOMATED_IMPORT_PROCESS_SUCCESS
0 samples, average = 0, sum = 0

After selecting Archived Ping Data:

FX_STARTUP_MIGRATION_AUTOMATED_IMPORT_PROCESS_SUCCESS
2 samples, average = 2.5, sum = 5

0 |#########################  1  50%
5 |#########################  1  50%
6 |  0  0%

Per Comment 5 - 

browser.migrate.automigrate.enabled is set to true

Hmm, when I open up Program Files, I do see Mozilla Firefox dll files from 1/25/2017, even after uninstalling from Control Panel and clearing %APPDATA%. Are these the leftover files that need to be cleared for automigration to work?

Comment 8

[u554753]

Correction to Comment 7: 

For the import window to not appear*.

Comment 9

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Thanks for the info, so it's failing in pickProfile as in my example in comment 4.

I suggest setting a different browser as default before running the install, but if you want we can try to see where it is failing with your Chrome profile.

When Firefox comes up after the migration is done (you can just cancel it), hit Ctrl-Shift-J and the Browser Console will come up. If you scroll to the top it should have an error from AutoMigrate.jsm (the file name is listed on the right). Mine says
> Don't know how to pick a profile when more than 1 profile is present.        AutoMigrate.jsm:174
(Sorry I didn't have you look for this before, I just now realized that this is where the actual exception is logged).

I don't think the leftover DLLs are an issue here. Also thanks for confirming that it's running f=99!

Comment 10

[u554753]

This is the error I am getting:

Could not read chrome manifest 'file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/chrome.manifest'.

Don't know how to pick a profile when more than 1 profile is present.  AutoMigrate.jsm:174
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]  XULStore.js:66

Error reading typed URL history: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWindowsRegKey.open]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/MSMigrationUtils.jsm :: getTypedURLs :: line 666"  data: no]

Comment 11

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Ok, so that seems to settle it, automigrate is failing because of multiple Chrome profiles, so it is falling back to the manual dialog. This is by design (to the best of my knowledge).

I guess you could try removing a profile, or switching to a different default browser, so it doesn't hit this issue.

Comment 12

[u554753]

Works as intended when Edge is set as default browser. Is this intended functionality where this is ignored if it can't resolve a profile to use?

Comment 13

[Verdi [:verdi] Best to slack me]

(In reply to Adam Gashlin [:agashlin] from comment #11)
> Ok, so that seems to settle it, automigrate is failing because of multiple
> Chrome profiles, so it is falling back to the manual dialog. This is by
> design (to the best of my knowledge).
> 
> I guess you could try removing a profile, or switching to a different
> default browser, so it doesn't hit this issue.

Correct, automigration won't happen if we encounter multiple chrome profiles because we don't have a way to guess which one we should import from.

Comment 14

[:Gijs (he/him)]

Adam and Verdi are correct, we don't know how to decide between multiple Chrome profiles. This is tracked as bug 1277294.

Comment 15

[Verdi [:verdi] Best to slack me]

It's too late to fix bug 1277294 to affect funnelcake 99 so I'm going to close this as wfm and make it block the next onboarding meta bug 1332318.