Closed Bug 1336638 Opened 8 years ago Closed 5 years ago

Intermittent toolkit/components/alerts/test/test_principal.html | Should include source for node principal - got undefined, expected "via mochi.test:8888"

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Type:
defect

Tracking

(firefox57 disabled, firefox58 disabled, firefox83 fixed)

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox57 --- disabled
firefox58 --- disabled
firefox83 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(2 files)

disable the test case on windows 7
763 bytes, patch
MattN
: review+
Details | Diff | Splinter Review
Bug 1336638 - re-enable test_principal.html on Windows, r?jmaher
47 bytes, text/x-phabricator-request
Details | Review
this started failing on August 17th, primarily on windows10 and windows7
Component: General → Notifications and Alerts
here is a recent win10 debug log: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=124512628 and related screenshot: https://public-artifacts.taskcluster.net/dNfwwBoTTk63q0nyEsg5WA/0/public/test_info/mozilla-test-fail-screenshot_ogsg3e.png data from the log: 09:54:42 INFO - 1755 INFO TEST-PASS | toolkit/components/alerts/test/test_principal.html | Should hide alert 09:54:42 INFO - 1756 INFO TEST-PASS | toolkit/components/alerts/test/test_principal.html | Should omit source for system principal 09:54:42 INFO - 1757 INFO SpawnTask.js | Leaving test testSystemPrincipal 09:54:42 INFO - 1758 INFO SpawnTask.js | Entering test testNullPrincipal 09:54:42 INFO - 1759 INFO TEST-PASS | toolkit/components/alerts/test/test_principal.html | Should hide alert 09:54:42 INFO - 1760 INFO TEST-PASS | toolkit/components/alerts/test/test_principal.html | Should omit source for null principal 09:54:42 INFO - 1761 INFO SpawnTask.js | Leaving test testNullPrincipal 09:54:42 INFO - 1762 INFO SpawnTask.js | Entering test testNodePrincipal 09:54:42 INFO - 1763 INFO TEST-PASS | toolkit/components/alerts/test/test_principal.html | Should hide alert 09:54:42 INFO - Buffered messages finished 09:54:42 ERROR - 1764 INFO TEST-UNEXPECTED-FAIL | toolkit/components/alerts/test/test_principal.html | Should include source for node principal - got undefined, expected "via mochi.test:8888" 09:54:42 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:312:5 09:54:42 INFO - testNodePrincipal@toolkit/components/alerts/test/test_principal.html:92:3 09:54:42 INFO - async*add_task/</<@SimpleTest/SpawnTask.js:298:21 09:54:42 INFO - onFulfilled@SimpleTest/SpawnTask.js:69:15 09:54:42 INFO - promise callback*next@SimpleTest/SpawnTask.js:104:45 09:54:42 INFO - onFulfilled@SimpleTest/SpawnTask.js:73:7 09:54:42 INFO - promise callback*next@SimpleTest/SpawnTask.js:104:45 09:54:42 INFO - onFulfilled@SimpleTest/SpawnTask.js:73:7 09:54:42 INFO - promise callback*next@SimpleTest/SpawnTask.js:104:45 09:54:42 INFO - onFulfilled@SimpleTest/SpawnTask.js:73:7 09:54:42 INFO - co/<@SimpleTest/SpawnTask.js:58:5 09:54:42 INFO - co@SimpleTest/SpawnTask.js:54:10 09:54:42 INFO - setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:676:12 09:54:42 INFO - add_task@SimpleTest/SpawnTask.js:271:7 09:54:42 INFO - runTest@toolkit/components/alerts/test/test_principal.html:113:3 09:54:42 INFO - @toolkit/components/alerts/test/test_principal.html:119:1 09:54:42 INFO - 1765 INFO SpawnTask.js | Leaving test testNo dePrincipal :mattn, this is trending to be one of the top failures- is this something you could look at or help find someone to look at?
Flags: needinfo?(MattN+bmo)
Whiteboard: [stockwell needswork]
Unfortunately nobody is currently maintaining the alert service and I believe the three people who know it best: Myself, Kit, and Jared are all busy. This test doesn't run on OS X and maybe not Linux where we have a system alert service so I really don't want to disable it. Perhaps we can disable it only on Win7 to reduce the volume for now?
Priority: -- → P1
we could disable it on win7, or just debug and keep it for win7/10 opt+pgo if you want. I agree that we should ensure we have some coverage of this vs disabling it everywhere.
you can see we have a fairly even distribution of failures on the windows configs: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1336638 windows 7 should reduce the pain a bit!
Attachment #8903166 - Flags: review?(MattN+bmo)
Comment on attachment 8903166 [details] [diff] [review] disable the test case on windows 7 Review of attachment 8903166 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #8903166 - Flags: review?(MattN+bmo) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ac3ad576f15 Disable toolkit/components/alerts/test/test_principal.html on windows 7. r=mattn
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
Should actually be very easy to reproduce: just take a weekday off, and then work either Saturday or Sunday, because this failure has massive peaks on weekends, https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1336638&endday=2017-09-16&startday=2017-08-10&tree=trunk&branch=trunk
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/30a5c8bbe60f Disable toolkit/components/alerts/test/test_principal.html on windows for frequent failures. r=me, a=test-only
disabled this on win10 as well given the high failure rate.
Flags: needinfo?(MattN+bmo)
Moving to p3 because no activity for at least 24 weeks.
Priority: P1 → P3
Priority: P3 → P1

Matt, you moved this back to P1 but there's no assignee and nothing's happened for 2 years. What do you want to do about this test (which is disabled on all of Windows right now, not just win7) ? :-)

Flags: needinfo?(MattN+bmo)

It needs to be fixed to prevent shipping a security bug.

Severity: normal → S3
Flags: needinfo?(mozilla+bmo)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/62876238d787 re-enable test_principal.html on Windows, r=jmaher

Been on autoland 24h, gonna call it.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox83: --- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [stockwell disabled] → [stockwell fixed]
Target Milestone: --- → 83 Branch
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: