Closed Bug 1336643 Opened 7 years ago Closed 7 years ago

We release nsCSSValues off-main-thread

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bholley, Unassigned)

References

Details

(Keywords: sec-audit)

Attachments

(1 file)

stack
3.26 KB, text/plain
Details 
In bug 1335308, I'm adding some assertions to make sure that we don't call Release() on any nsCSSValue variants that share ownership of data via non-threadsafe refcounts.

https://treeherder.mozilla.org/logviewer.html#?job_id=74417863&repo=try&lineNumber=2116

Not sure if this is a real hazard, but marking s-s to be safe.
Attached file stack — 
Brian, is this OMTA code?
Flags: needinfo?(bbirtles)
See Also: → 1335308
Yes, that's right. layers::SampleAnimations runs on the compositor thread/process.
Flags: needinfo?(bbirtles)
The instance is generated on the compositor thread, and used only on the compositor (if I am missing something).
Keywords: sec-audit
Per comment 3, this isn't a security issue.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Group: core-security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: