1336706 - when we generate performance alerts, the summary doesn't show e10s for the test

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I have been seeing double alerts for a couple weeks and assumed it was something else.  For example I see ts_paint on win8 a couple times but only one change on the graph, looking closer at both alerts, one is e10s and the other is non-e10s (when clicking the 'graph' link).

We need to display this information properly in the alerts dashboard.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] rwood-moz:bug1336706 > mozilla:master

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8833684 [details] [review]
[treeherder] rwood-moz:bug1336706 > mozilla:master

thanks for fixing this so fast!

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/eb842830b60f04613e9b16dcd6e43dedb9f379c3
Bug 1336706 - Fix performance alert summary (#2135)

Comment 4

[William Lachance (:wlach)]

Unfortunately this did not seem to fix the issues. The following alerts are still displaying as non-e10s even though their signature has the e10s property:

https://treeherder.mozilla.org/perf.html#/alerts?id=4988

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] rwood-moz:bug1336706-take2 > mozilla:master

Comment 6

[Robert Wood [:rwood]]

Comment on attachment 8834624 [details] [review]
[treeherder] rwood-moz:bug1336706-take2 > mozilla:master

I *believe* this should fix it. I haven't tested this on staging yet.

Comment 7

[Robert Wood [:rwood]]

Comment on attachment 8834624 [details] [review]
[treeherder] rwood-moz:bug1336706-take2 > mozilla:master

Tested this out on treeherder-prototype. It fixed the alert titles, the test options were added i.e. 'e10s' to the alert titles. However this patch breaks the graph url titles, the subtest titles, and the e10s dashboard. :( So back to the drawing board.

Comment 8

[Robert Wood [:rwood]]

I've spent several hours on this and can't seem to figure it out, sorry but need some help with this one, thanks!

Comment 9

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master

Comment 10

[Robert Wood [:rwood]]

Comment on attachment 8835025 [details] [review]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master

Thanks for going through the code with me :wlach, appreciated! I have a couple lint errors still to fix but here's the PR

Comment 11

[William Lachance (:wlach)]

Comment on attachment 8835025 [details] [review]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master

r+ with linter errors fixed :)

Comment 12

[Robert Wood [:rwood]]

Comment on attachment 8835025 [details] [review]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master

Messed that pull request up, it is from mozilla: not from my repo

Comment 13

[Ed Morley [:emorley]]

(In reply to Robert Wood [:rwood] from comment #12)
> Messed that pull request up, it is from mozilla: not from my repo

That's not a problem - some of us use own repo, others use the mozilla/treeherder repo as base.

Comment 14

[Robert Wood [:rwood]]

Comment on attachment 8835025 [details] [review]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master

Ok, thanks, will fix the lint errors in this same PR

Comment 15

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6ca8d8ab6a7b3385a8ccbdcb38819b2784e68ec2
Bug 1336706 - Test options not showing in perf alert titles (#2145)