1336778 - Remove always-false #if WINVER < 0x0601 (Windows 7) checks

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Chris Peterson [:cpeterson]]

As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1336778 - Part 1: Remove always-false #if WINVER < _WIN32_WINNT_WIN7 (0x0601) check in dom/media.

As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).

Review commit: https://reviewboard.mozilla.org/r/109906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109906/

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1336778 - Part 2: Remove always-false #if WINVER < 0x0600 (Windows Vista) checks in widget/windows.

As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).

Review commit: https://reviewboard.mozilla.org/r/109908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109908/

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1336778 - Part 3a: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsLookAndFeel.h.

As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).

Review commit: https://reviewboard.mozilla.org/r/109910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109910/

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Bug 1336778 - Part 4: Remove always-false #if WINVER < 0x0600 (Windows Vista) check in toolkit/win.

As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).

Review commit: https://reviewboard.mozilla.org/r/109912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109912/

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8833719 [details]
Bug 1336778 - Part 1: Remove always-false #if WINVER < _WIN32_WINNT_WIN7 (0x0601) check in dom/media.

https://reviewboard.mozilla.org/r/109906/#review110896

Comment 6

[Chris Peterson [:cpeterson]]

Here is a (nearly) green Try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9384b6888becd20ec9a905d2bd3af26e7b524d7

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8833720 [details]
Bug 1336778 - Part 2: Remove always-false #if WINVER < 0x0600 (Windows Vista) checks in widget/windows.

https://reviewboard.mozilla.org/r/109908/#review111134

Comment 8

[Jim Mathies [:jimm]]

(In reply to Chris Peterson [:cpeterson] from comment #2)
> Created attachment 8833720 [details]
> Bug 1336778 - Part 2: Remove always-false #if WINVER < 0x0600 (Windows
> Vista) checks in widget/windows.
> 
> As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).
> 
> Review commit: https://reviewboard.mozilla.org/r/109908/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/109908/

mozreview barfed in this changeset, I can't see it. Can you post a diff?

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 8833722 [details]
Bug 1336778 - Part 4: Remove always-false #if WINVER < 0x0600 (Windows Vista) check in toolkit/win.

https://reviewboard.mozilla.org/r/109912/#review111136

Comment 10

[Chris Peterson [:cpeterson]]

Comment on attachment 8833719 [details]
Bug 1336778 - Part 1: Remove always-false #if WINVER < _WIN32_WINNT_WIN7 (0x0601) check in dom/media.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109906/diff/1-2/

Comment 11

[Chris Peterson [:cpeterson]]

Comment on attachment 8833720 [details]
Bug 1336778 - Part 2: Remove always-false #if WINVER < 0x0600 (Windows Vista) checks in widget/windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109908/diff/1-2/

Comment 12

[Chris Peterson [:cpeterson]]

Comment on attachment 8833721 [details]
Bug 1336778 - Part 3a: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsLookAndFeel.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109910/diff/1-2/

Comment 13

[Chris Peterson [:cpeterson]]

Comment on attachment 8833722 [details]
Bug 1336778 - Part 4: Remove always-false #if WINVER < 0x0600 (Windows Vista) check in toolkit/win.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109912/diff/1-2/

Comment 14

[Chris Peterson [:cpeterson]]

Attachment: Bug 1336778 - Part 3b: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsWinGesture.h.

Review commit: https://reviewboard.mozilla.org/r/110176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110176/

Comment 15

[Chris Peterson [:cpeterson]]

Comment on attachment 8833721 [details]
Bug 1336778 - Part 3a: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsLookAndFeel.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109910/diff/2-3/

Comment 16

[Chris Peterson [:cpeterson]]

Comment on attachment 8833722 [details]
Bug 1336778 - Part 4: Remove always-false #if WINVER < 0x0600 (Windows Vista) check in toolkit/win.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109912/diff/2-3/

Comment 17

[Chris Peterson [:cpeterson]]

Attachment: bug-1336778-part-3.patch

Part 3b: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsWinGesture.h.

Something about widget/windows/nsWinGesture.h seems to make mozreview sad, so I've attached that commit as a patch here.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9ba6b3da629
Part 1: Remove always-false #if WINVER < _WIN32_WINNT_WIN7 (0x0601) check in dom/media. r=cpearce
https://hg.mozilla.org/integration/mozilla-inbound/rev/df0ad0c6a960
Part 2: Remove always-false #if WINVER < 0x0600 (Windows Vista) checks in widget/windows. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/629a2481d519
Part 4: Remove always-false #if WINVER < 0x0600 (Windows Vista) check in toolkit/win. r=jimm

Comment 19

[Chris Peterson [:cpeterson]]

leave open until parts 3a and 3b are reviewed and land

Comment 20

[Masatoshi Kimura [:emk]]

I think we can move some files back to UNIFIED_SOURCE.

Comment 21

[Chris Peterson [:cpeterson]]

(In reply to Masatoshi Kimura [:emk] from comment #20)
> I think we can move some files back to UNIFIED_SOURCE.

Good catch! I hadn't checked if these files could be unified now.

Comment 22

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e9ba6b3da629
https://hg.mozilla.org/mozilla-central/rev/df0ad0c6a960
https://hg.mozilla.org/mozilla-central/rev/629a2481d519

Comment 23

[Jim Mathies [:jimm]]

Comment on attachment 8833721 [details]
Bug 1336778 - Part 3a: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsLookAndFeel.h.

https://reviewboard.mozilla.org/r/109910/#review111940

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b04e3138909
Part 3a: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsLookAndFeel.h. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/c26373db6d52
Part 3b: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsWinGesture.h. r=jimm

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b04e3138909
https://hg.mozilla.org/mozilla-central/rev/c26373db6d52