Closed Bug 1336778 Opened 3 years ago Closed 3 years ago

Remove always-false #if WINVER < 0x0601 (Windows 7) checks

Categories

(Core :: General, defect)

51 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(5 files, 1 obsolete file)

As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).
Comment on attachment 8833719 [details]
Bug 1336778 - Part 1: Remove always-false #if WINVER < _WIN32_WINNT_WIN7 (0x0601) check in dom/media.

https://reviewboard.mozilla.org/r/109906/#review110896
Attachment #8833719 - Flags: review?(cpearce) → review+
Comment on attachment 8833720 [details]
Bug 1336778 - Part 2: Remove always-false #if WINVER < 0x0600 (Windows Vista) checks in widget/windows.

https://reviewboard.mozilla.org/r/109908/#review111134
Attachment #8833720 - Flags: review?(jmathies) → review+
(In reply to Chris Peterson [:cpeterson] from comment #2)
> Created attachment 8833720 [details]
> Bug 1336778 - Part 2: Remove always-false #if WINVER < 0x0600 (Windows
> Vista) checks in widget/windows.
> 
> As of bug 1325299, WINVER is always >= 0x0601 (Windows 7).
> 
> Review commit: https://reviewboard.mozilla.org/r/109908/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/109908/

mozreview barfed in this changeset, I can't see it. Can you post a diff?
Comment on attachment 8833722 [details]
Bug 1336778 - Part 4: Remove always-false #if WINVER < 0x0600 (Windows Vista) check in toolkit/win.

https://reviewboard.mozilla.org/r/109912/#review111136
Attachment #8833722 - Flags: review?(jmathies) → review+
Attachment #8833721 - Flags: review?(jmathies)
Part 3b: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsWinGesture.h.

Something about widget/windows/nsWinGesture.h seems to make mozreview sad, so I've attached that commit as a patch here.
Attachment #8834134 - Attachment is obsolete: true
Attachment #8834134 - Flags: review?(jmathies)
Attachment #8834139 - Flags: review?(jmathies)
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9ba6b3da629
Part 1: Remove always-false #if WINVER < _WIN32_WINNT_WIN7 (0x0601) check in dom/media. r=cpearce
https://hg.mozilla.org/integration/mozilla-inbound/rev/df0ad0c6a960
Part 2: Remove always-false #if WINVER < 0x0600 (Windows Vista) checks in widget/windows. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/629a2481d519
Part 4: Remove always-false #if WINVER < 0x0600 (Windows Vista) check in toolkit/win. r=jimm
leave open until parts 3a and 3b are reviewed and land
Keywords: leave-open
I think we can move some files back to UNIFIED_SOURCE.
(In reply to Masatoshi Kimura [:emk] from comment #20)
> I think we can move some files back to UNIFIED_SOURCE.

Good catch! I hadn't checked if these files could be unified now.
Comment on attachment 8833721 [details]
Bug 1336778 - Part 3a: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsLookAndFeel.h.

https://reviewboard.mozilla.org/r/109910/#review111940
Attachment #8833721 - Flags: review?(jmathies) → review+
Attachment #8834139 - Flags: review?(jmathies) → review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b04e3138909
Part 3a: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsLookAndFeel.h. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/c26373db6d52
Part 3b: Remove always-false #if WINVER < 0x0601 (Windows 7) checks in nsWinGesture.h. r=jimm
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/5b04e3138909
https://hg.mozilla.org/mozilla-central/rev/c26373db6d52
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.