Closed Bug 1336877 Opened 7 years ago Closed 7 years ago

Remove unneeded stackwalk lock code added in Gecko profiler hang bug 1263595

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86_64
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox51 --- wontfix
firefox52 --- ?
firefox53 --- ?
firefox54 --- affected

People

(Reporter: cpeterson, Unassigned)

References

Details

In bug 1323460 comment 9, Jan said that the stackwalk lock code added in bug 1263595 could be backed out because the JS engine no longer touches Win64 function tables between XPCOM init and shutdown, so Gecko profiler hang bug 1323460 is no longer possible.
Depends on: CVE-2017-5400
We need to be careful with the profiler sampling JS_InitWithFailureDiagnostic (where we still call RtlAddFunctionTable) or JS_Shutdown (where we still call RtlDeleteFunctionTable), because in these cases we stil need the lock AIUI.

Removing the lock would be great, though.
We can't remove this lock as it's also needed to avoid deadlocks caused by the stack walking code itself, see analysis in bug 1337499.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.