Closed Bug 1336886 Opened 7 years ago Closed 7 years ago

Compare V2 and V4 lookup times

Categories

(Toolkit :: Safe Browsing, defect, P3)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: francois, Assigned: dimi)

References

Details

(Whiteboard: #sbv4-m7)

The URLCLASSIFIER_LOOKUP_TIME probe is not keyed and so we can't compare the lookup performance of the V2 code with the one for V4. This could be useful to detect any regressions when moving from V2 to V4.

Of course, this lookup time will be influenced by the difference in server response time on the Google side.
Whiteboard: #sbv4-m7
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Hi Francois,
When you said URLCLASSIFIER_LOOKUP_TIME do you mean this one?
https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#312

If yes, this is used to telemetry the local lookup time and it contains all the tables we enabled(include V2 and V4).
We iterate through all the tables in Classifier::Check[1] so it will be complex to separate for different providers.

[1] https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/Classifier.cpp#445
Flags: needinfo?(francois)
(In reply to Dimi Lee[:dimi][:dlee] from comment #1)
> If yes, this is used to telemetry the local lookup time and it contains all
> the tables we enabled(include V2 and V4).
> We iterate through all the tables in Classifier::Check[1] so it will be
> complex to separate for different providers.

Ok, it may not be worth the trouble then.

We already know that the server response times are better in V4 so we shouldn't see a performance regression here.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(francois)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.