Closed
Bug 1336956
Opened 8 years ago
Closed 7 years ago
Split CompositableOperation related functions from CompositableHost
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: jerry, Assigned: jerry)
References
Details
Attachments
(1 file)
There is no compositor when we use webrender for composition(we will use RenderOGL which is not inherit from compositor). And we also want to add more webrender specific things(e.g. we will have renader thread) for CompositableHost.
So, I'm trying to split CompositableOperation related functions into a CompositableHostBase(I don't have a good name right now) and use this new base class in CompositableParentManager::ReceiveCompositableUpdate().
CompositableHost will have all compositor related functions, and WebrenderCompositableHost will only have webrender specific logic.
The class diagram will be:
CompositableHostBase <----- WebrenderCompositableHost
^
|
+----------- CompositableHost
Assignee | ||
Comment 1•8 years ago
|
||
MozReview-Commit-ID: GD4JKbpgcfT
Assignee | ||
Comment 2•8 years ago
|
||
I create a base class CompositableBase for both CompositableHost and WebrenderCompositableHost.
It has to method: AsCompositableHost() and AsWebrenderCompositableHost().
That could be used for original gecko code or WR specific flow.
Any comment here?
Flags: needinfo?(sotaro.ikeda.g)
Flags: needinfo?(nical.bugzilla)
Comment 3•8 years ago
|
||
I prefer not to have CompositableBase for now, since we are going to have only WebRenderImageHost as WebrenderCompositableHost.
In Bug 1336021, I created WebRenderImageHost, it looks simple enough without CompositableBase.
Flags: needinfo?(sotaro.ikeda.g)
Comment 4•8 years ago
|
||
I just thought that creating CompositableBase might be too much just for WebRenderImageHost.
Updated•8 years ago
|
Flags: needinfo?(nical.bugzilla)
Updated•7 years ago
|
Blocks: stage-wr-backlog
Assignee | ||
Comment 5•7 years ago
|
||
With bug 1336021, there is no need to have this approach.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•