1336994 - Fix two -Wmax-unsigned-zero warnings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Building with clang 4.0 rc1 + --enable-warnings-as-errors, the build breaks with:
 0:06.53 /home/sylvestre/dev/mozilla/mozilla-central.hg/dom/html/HTMLImageElement.cpp:773:14: error: taking the max of a value and unsigned zero is always equal to the other value [-Werror,-Wmax-unsigned-zero]
 0:06.53     height = std::max(height, 0u);
 0:06.53              ^~~~~~~~         ~~
 0:06.53 /home/sylvestre/dev/mozilla/mozilla-central.hg/dom/html/HTMLImageElement.cpp:773:14: note: remove call to max function and unsigned zero argument
 0:06.53     height = std::max(height, 0u);
 0:06.53              ^~~~~~~~       ~~~~
 0:06.53 /home/sylvestre/dev/mozilla/mozilla-central.hg/dom/html/HTMLImageElement.cpp:801:13: error: taking the max of a value and unsigned zero is always equal to the other value [-Werror,-Wmax-unsigned-zero]
 0:06.53     width = std::max(width, 0u);
 0:06.53             ^~~~~~~~        ~~

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1336994 - Fix two -Wmax-unsigned-zero warnings (std::max(unsigned int, 0u)

Review commit: https://reviewboard.mozilla.org/r/110102/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110102/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8833996 [details]
Bug 1336994 - Fix two -Wmax-unsigned-zero warnings (std::max(unsigned int, 0u)

https://reviewboard.mozilla.org/r/110102/#review111092

Yeah, it's bunk to do that given that height/width are unsigned...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6332ef237e21
Fix two -Wmax-unsigned-zero warnings (std::max(unsigned int, 0u) r=bz

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6332ef237e21