1337065 - Use more of the Cocoa API in OSPreferences

Status: NEW

(Core :: Widget: Cocoa, enhancement, P4)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

In bug 1333184 we're introducing OSPreferences API. In this bug we'll work on using more of the Cocoa API to handle more of the information from the OS.

Comment 1

[Markus Stange [:mstange]]

Once you have an OSPreferences API for the country code, you can remove GetSelectedCityInfo and MacHelpers.h/.mm.

Comment 2

[Martin Boros]

I'd like to try this if I had a bit of guidance on what was needed. I'm not familiar with Cocoa (I have developed iOS with Cocoa Touch), but I'm willing to read around and figure it out.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hi Martin - great to hear! I'll be happy to mentor you to the best of my ability.

The current code lives in http://searchfox.org/mozilla-central/source/intl/locale/mac/OSPreferences_mac.cpp

What I'd like to see is:

 - check if http://searchfox.org/mozilla-central/rev/b425854d9bbd49d5caf9baef3686e49ec91c17ec/intl/locale/mac/OSPreferences_mac.cpp#19 are the correct API calls to get the currently selected user locale
 - check if there's a way to hook us into any event system from MacOS to react to language/locale change in the OS and fire a "systemlocaleschange" event in Gecko.
 - go through Mac HiG for any other alignments we should do with regards to system locale, and regional preferences.

Thanks!

Comment 4

[Suhail Singh Bains]

Hi, Can I please be assigned this bug, would love to solve this.
Thanks

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hi Suhail!
Thank you for your interest!

Please, start working on it at will and we will assign the bug once you submit the initial patch.