1337129 - include LocaleService.h not found from gtest/TestLocaleService.cpp:7:27

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[:aceman]

I get a permanent compile error: mozilla/intl/locale/tests/gtest/TestLocaleService.cpp:7:27: fatal error: LocaleService.h: File does not exist

This is on Slackware linux, 64 bit, gcc 5.4.
This appeared somewhere in the last month (I updated from Dec 20th straight to Feb 04th 2017).

I do have that file in src/intl/locale and in objdir/dist/include/mozilla/intl/ , which seems correct.

As discussed on IRC (#developers), changing to #include "../../localeService.h" fixes compiling that file.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

:jfkthame - should we do something about our include paths?

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Fix up #include paths used in unit tests for new intl services

:aceman, if you apply this patch, does it resolve the problem for you?

Comment 3

[:aceman]

Yes, this works for me, thanks.

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 8834427 [details] [diff] [review]
Fix up #include paths used in unit tests for new intl services

I think this is a more correct way to deal with the paths.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8834427 [details] [diff] [review]
Fix up #include paths used in unit tests for new intl services

lgtm!

Comment 6

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18d066fac5dbd8ba11a61b650c65c88547fc8c6a
Bug 1337129 - Fix up #include paths used in unit tests for new intl services. r=gandalf

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18d066fac5db