1337157 - privacy.resistFingerprinting should disable WEBGL_debug_renderer_info

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P2)

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

Comment 2

[Tom Ritter [:tjr]]

P2 to investigate then re-assess

Comment 3

[Tom Ritter [:tjr]]

((If this lands, need to update the fingerprinting wiki page.))

Comment 4

[Tom Ritter [:tjr]]

Attachment: Bug 1337157 Disable WEBGL_debug_renderer_info when Resist Fingerprinting is active

Review commit: https://reviewboard.mozilla.org/r/231846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231846/

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8963000 [details]
Bug 1337157 Disable WEBGL_debug_renderer_info when Resist Fingerprinting is active

https://reviewboard.mozilla.org/r/231846/#review238132

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35db8e10d775
Disable WEBGL_debug_renderer_info when Resist Fingerprinting is active r=jgilbert

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/35db8e10d775

Comment 8

[Tom Ritter [:tjr]]

Comment on attachment 8963000 [details]
Bug 1337157 Disable WEBGL_debug_renderer_info when Resist Fingerprinting is active

Approval Request Comment
[Feature/Bug causing the regression]: An improvement to Resist Fingerprinting

[User impact if declined]: Tor will have to carry the patch themselves, and ESR will lack the protection

[Is this code covered by automated tests?]: No

[Has the fix been verified in Nightly?]: Yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: No

[Why is the change risky/not risky?]: One line change to a boolean.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8963000 [details]
Bug 1337157 Disable WEBGL_debug_renderer_info when Resist Fingerprinting is active

Approved for 60.0b9.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d8c0fba8b94a

Comment 11

[Andrei Vaida [:avaida]]

(In reply to Tom Ritter [:tjr] from comment #8)
> [Is this code covered by automated tests?]: No
> 
> [Has the fix been verified in Nightly?]: Yes
> 
> [Needs manual test from QE? If yes, steps to reproduce]: No
> 
> [List of other uplifts needed for the feature/fix]: None
> 
> [Is the change risky?]: No
> 
> [Why is the change risky/not risky?]: One line change to a boolean.

Setting qe-verify- based on Tom's assessment on manual testing needs and the fact that this fix consists of a small, unrisky change.

Comment 12

[Florian Scholz (Open Web Docs)]

Developer release notes for Firefox 60:
https://developer.mozilla.org/en-US/Firefox/Releases/60#Canvas_and_WebGL

Reference page update:
https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_debug_renderer_info