1337186 - Convert tests docshell/navigation/test_bug386782 to not rely on principal inheritance for data: URIs

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Description

[Christoph Kerschbaumer [:ckerschb]]

Flip pref [1] to 'false' and update tests within docshell/ to still work with new data: URI behavior.

[1] pref ("security.data_uri.inherit_security_context", true);

Comment 1

[Boris Zbarsky [:bzbarsky]]

Just so we're clear, the problem is not just tests that _fail_ with the pref flipped.  It's also tests that stop testing what they should be testing completely and always pass instead.

Comment 2

[Frederik Braun [:freddy]]

Let's discuss in the tracker.

Comment 3

[Frederik Braun [:freddy]]

Attachment: Bug 1337186 - rm data: from navigation/test_bug386782

Review commit: https://reviewboard.mozilla.org/r/112960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112960/

Comment 4

[Frederik Braun [:freddy]]

Attachment: Bug 1337186 - rm trailing whitespaces from navigation/test_bug386782

Review commit: https://reviewboard.mozilla.org/r/112962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112962/

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8837961 [details]
Bug 1337186 - rm trailing whitespaces from navigation/test_bug386782

https://reviewboard.mozilla.org/r/112962/#review114496

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8837960 [details]
Bug 1337186 - rm data: from navigation/test_bug386782

https://reviewboard.mozilla.org/r/112960/#review114498

Could you please not add any .trim() calls, but just have the new test files so that they don't add new \n.

Comment 7

[Frederik Braun [:freddy]]

Comment on attachment 8837960 [details]
Bug 1337186 - rm data: from navigation/test_bug386782

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112960/diff/1-2/

Comment 8

[Frederik Braun [:freddy]]

Comment on attachment 8837961 [details]
Bug 1337186 - rm trailing whitespaces from navigation/test_bug386782

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112962/diff/1-2/

Comment 9

[Frederik Braun [:freddy]]

Try looks good https://treeherder.mozilla.org/#/jobs?repo=try&revision=198583e8a89f
Please check in.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ede9c537f63
rm data: from navigation/test_bug386782 r=smaug
https://hg.mozilla.org/integration/autoland/rev/29fc06e777d6
rm trailing whitespaces from navigation/test_bug386782 r=smaug

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ede9c537f63
https://hg.mozilla.org/mozilla-central/rev/29fc06e777d6

Comment 12

[Christoph Kerschbaumer [:ckerschb]]

Wes, I suppose those changes already got merged into mc, right? Can we mark it as resolved?

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Freddyb added the leave-open keyword, resolving isn't my call. :)

Comment 14

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Wes Kocher (:KWierso) from comment #13)
> Freddyb added the leave-open keyword, resolving isn't my call. :)

oh sorry, I haven't realized that.