Custom Tabs: progress bar on the custom bar for loading page

VERIFIED FIXED in Firefox 55

Status

()

Firefox for Android
General
VERIFIED FIXED
10 months ago
8 months ago

People

(Reporter: ryang, Assigned: walkingice)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

progress bar is needed on the custom bar for displaying the loading page.
(Reporter)

Updated

10 months ago
Blocks: 1337236
Summary: Cutom Tabs: progress bar on the custom bar for loading page → Custom Tabs: progress bar on the custom bar for loading page
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee: nobody → walkingice0204
Status: NEW → ASSIGNED

Comment 3

8 months ago
mozreview-review
Comment on attachment 8848966 [details]
Bug 1337238 - Reuse some id resources in layout xml file

https://reviewboard.mozilla.org/r/121810/#review123844

Why is it toolbar->actionbar, but progress -> toolbar_progress? Should be both 'toolbar' (or 'actionbar')? :)
Attachment #8848966 - Flags: review?(s.kaspari) → review+

Comment 4

8 months ago
mozreview-review
Comment on attachment 8848967 [details]
Bug 1337238 - Involve ProgressBar to CustomTabsActivity for page loading

https://reviewboard.mozilla.org/r/121812/#review123848

Yeah \o/

This was super annoying without a progress bar. :)
Attachment #8848967 - Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 7

8 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d05c2e4eef15
Reuse some id resources in layout xml file r=sebastian
https://hg.mozilla.org/integration/autoland/rev/d6b50ff5c020
Involve ProgressBar to CustomTabsActivity for page loading r=sebastian
Keywords: checkin-needed

Comment 8

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d05c2e4eef15
https://hg.mozilla.org/mozilla-central/rev/d6b50ff5c020
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Created attachment 8853919 [details]
Screenshot_2017-04-03-12-03-05.png

Verified as fixed in build 55.0a1 (2017-04-02).
Device: Huawei Honor (Android 5.1.1). Progress bar is displayed when a page is loading.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.