If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Uplift cubeb to revision 927877

RESOLVED FIXED in Firefox 54

Status

()

Core
Audio/Video: cubeb
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
This brings in:
- Drift fix on WASAPI
- Fix default device selection on Pulse
- Test code simplification
- Allow using MOZ_ASSERT inside cubeb
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Assignee: nobody → padenot

Comment 2

8 months ago
mozreview-review
Comment on attachment 8834346 [details]
Bug 1337328 - Uplift cubeb to revision 927877.

https://reviewboard.mozilla.org/r/110318/#review111492

Looks good, thanks
Attachment #8834346 - Flags: review?(achronop) → review+

Comment 3

8 months ago
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/6befd9682522
Uplift cubeb to revision 927877. r=achronop
(Assignee)

Comment 4

8 months ago
(https://treeherder.mozilla.org/#/jobs?repo=try&revision=05fb3346686d2de942c366e3d102c71953b20e99)
Duplicate of this bug: 1332887

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6befd9682522
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Duplicate of this bug: 1324987
By the way, I noticed that this turns XASSERT into a MOZ_ASSERT, where it was previously closer to a MOZ_RELEASE_ASSERT. As a result these assertions will be optimized out on all opt builds. If there are any important assertions that should receive testing outside of automation, it might be worth adding an XRELEASE_ASSERT or something to that effect that maps to MOZ_RELEASE_ASSERT.
(Assignee)

Comment 9

8 months ago
Yeah I'll fix that today, good catch.
Depends on: 1354547
You need to log in before you can comment on or make changes to this bug.