|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
This brings in: - Drift fix on WASAPI - Fix default device selection on Pulse - Test code simplification - Allow using MOZ_ASSERT inside cubeb
Comment on attachment 8834346 [details] Bug 1337328 - Uplift cubeb to revision 927877. https://reviewboard.mozilla.org/r/110318/#review111492 Looks good, thanks
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/6befd9682522 Uplift cubeb to revision 927877. r=achronop
By the way, I noticed that this turns XASSERT into a MOZ_ASSERT, where it was previously closer to a MOZ_RELEASE_ASSERT. As a result these assertions will be optimized out on all opt builds. If there are any important assertions that should receive testing outside of automation, it might be worth adding an XRELEASE_ASSERT or something to that effect that maps to MOZ_RELEASE_ASSERT.
Yeah I'll fix that today, good catch.