1337356 - Cannot undo in task tab or today pane

Status: VERIFIED FIXED

(Calendar :: Tasks, defect, P2)

Description

[Tristan Miller]

After deleting an event or task from the task tab or the today pane, the Undo command in the Edit window remains deactivated.  Please allow event/task deletions to be undone.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Wow I am surprised this feature was never added or even reported beforehand. Maybe I haven't found the duplicate bug though. Confirming.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to Philipp Kewisch [:Fallen] from comment #1)
> Wow I am surprised this feature was never added or even reported beforehand.
> Maybe I haven't found the duplicate bug though. Confirming.

There was Bug 258258 - Add "REDO" AND "UNDO" facility to calendar. But apparently it did not go far enough?

There is https://support.mozilla.org/en-US/questions/1172143

Comment 5

[Mozilla-User]

Hit by this bug again, today.  I thought I was in a spreadsheet, but the window focus was really on Thunderbird's Tasks tab.  I started entering a number with a decimal in it, and my task was deleted with no warning!

What happened also exposes another bug (for which I'll open a ticket):  the decimal key, if Num Lock is on, is not a delete key, but Thunderbird Lightning treats it as such.  Even pressing the keyboard's main period key (the key with the ">" and "." symbols) deletes a task if the task is highlighted!

Comment 6

[Mozilla-User]

Opened Mozilla Bugzilla 1409560 for the `period key is not a delete key` issue.

But re-looking at this cannot-undo-delete bug, I see it was opened against Lightning 4.7.7.  I'm currently using Lightning 5.4.3.  Should another bug be opened for that version?

Comment 7

[Magnus Melin [:mkmelin]]

Something needs hooking up. https://searchfox.org/comm-central/source/calendar/base/src/CalTransactionManager.jsm does support undo

Comment 8

[Mozilla-User]

Wow, I did not realize this Bugzilla ticket was still open. But yes, I see in my Thunderbird 78.10.1 that one can still not undo a task deletion.

Thanks, Magnus, for pointing out the code module and assigning this ticket to Lasana. (Good luck, Lasana.)

Comment 9

[Lasana Murray]

It appears that adding an event does not enable the undo menu either.

Comment 10

[Lasana Murray]

Attachment: Bug 1337356 - Enable undo/redo for event creation and deletion. r=darktrojan

This was accomplished by making the CalTransactionManager class aware of
batch transactions which can result in peeking of the transaction stack
to return null.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f4f406ddf3e
Enable undo/redo for event creation and deletion. r=darktrojan

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fbb43934b5ae
followup - fix linting. rs=eslint DONTBUILD

Comment 13

[Magnus Melin [:mkmelin]]

Bct1 on linux seems to be failing. https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=Trzeom4mSf6A4umSbRIZfA.0 (others still running)

Comment 14

[Lasana Murray]

I forgot to rebase after Geoff removed some of the lightning references.

Comment 15

[Lasana Murray]

Attachment: Bug 1337356 - Follow up: update lightning references in test. r=mkmelin

Also takes advantage of saveAndCloseItemDialog() new behaviour of
waiting for the dialog to be closed.

Comment 16

[Magnus Melin [:mkmelin]]

Geoff - please include in next push to fix tests.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d5d385497178
Follow up: update lightning references in test. r=mkmelin

Comment 20

[WaltS48 [:walts48]]

Verified using Thunderbird 91.0b4 on Fedora Linux.