Closed Bug 1337366 Opened 3 years ago Closed 3 years ago

Gecko-specific changes to support mozilla-esr52

Categories

(Release Engineering :: Release Automation: Other, defect, P1)

defect

Tracking

(firefox-esr52 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr52 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Comment on attachment 8834402 [details]
Bug 1337366 - Rename ESR52 partner repack config

https://reviewboard.mozilla.org/r/110368/#review111774

::: testing/mozharness/configs/merge_day/bump_esr.py:14
(Diff revision 1)
>          {"file": "browser/config/version_display.txt", "suffix": ""},
>          {"file": "config/milestone.txt", "suffix": ""},
>      ],
>      "tools_repo_url": "https://hg.mozilla.org/build/tools",
>      "tools_repo_branch": "default",
> -    "to_repo_url": "ssh://hg.mozilla.org/releases/mozilla-esr45",
> +    "to_repo_url": "ssh://hg.mozilla.org/releases/mozilla-esr52",

are we going to need to support both a 45 and 52 version bump for at least a few initial cycles?
Attachment #8834402 - Flags: review?(jlund) → review+
Comment on attachment 8834403 [details]
Bug 1337366 - Remove reference to unused latest_mar_dir

https://reviewboard.mozilla.org/r/110370/#review111776

::: testing/mozharness/mozharness/mozilla/building/buildbase.py
(Diff revision 1)
>                  mach_env['UPLOAD_SSH_KEY'] = mach_env['UPLOAD_SSH_KEY'] % {
>                      'stage_ssh_key': c['stage_ssh_key']
>                  }
>  
> -        if self.query_is_nightly():
> -            mach_env['LATEST_MAR_DIR'] = c['latest_mar_dir'] % {

ooo, I didn't realize or forgot this isn't used anymore.
Attachment #8834403 - Flags: review?(jlund) → review+
(In reply to Jordan Lund (:jlund) from comment #3)
> Comment on attachment 8834402 [details]
> Bug 1337366 - Gecko-specific changes to support mozilla-esr52
> 
> https://reviewboard.mozilla.org/r/110368/#review111774
> 
> ::: testing/mozharness/configs/merge_day/bump_esr.py:14
> (Diff revision 1)
> >          {"file": "browser/config/version_display.txt", "suffix": ""},
> >          {"file": "config/milestone.txt", "suffix": ""},
> >      ],
> >      "tools_repo_url": "https://hg.mozilla.org/build/tools",
> >      "tools_repo_branch": "default",
> > -    "to_repo_url": "ssh://hg.mozilla.org/releases/mozilla-esr45",
> > +    "to_repo_url": "ssh://hg.mozilla.org/releases/mozilla-esr52",
> 
> are we going to need to support both a 45 and 52 version bump for at least a
> few initial cycles?

Yes, but those configs are just fine in mozilla-esr45.
Comment on attachment 8834402 [details]
Bug 1337366 - Rename ESR52 partner repack config

https://reviewboard.mozilla.org/r/110368/#review111774

> are we going to need to support both a 45 and 52 version bump for at least a few initial cycles?

Actually yes... We don't have any suport for bumping 2 ESR releases at once at the moment. Until we implement something like that, we can just use the configs from the corresponding branches, mozilla-esr45 in this case.
Keywords: leave-open
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c76a46ccd74b
Gecko-specific changes to support mozilla-esr52 r=jlund
https://hg.mozilla.org/integration/autoland/rev/74050c8ec23b
Remove reference to unused latest_mar_dir r=jlund
the patch is for the mozilla-esr45 repo and created by:

 hg cat -r 66498480fe65 testing/mozharness/configs/merge_day/release_to_esr.py >! testing/mozharness/configs/merge_day/release_to_esr.py
Attachment #8837205 - Flags: review?(jlund) → review+
I think we are done here.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
One more file! https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/builds/branch_specifics.py#187
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8834403 - Attachment is obsolete: true
Attachment #8834402 - Flags: review+ → review?(jlund)
Comment on attachment 8834402 [details]
Bug 1337366 - Rename ESR52 partner repack config

https://reviewboard.mozilla.org/r/110368/#review115186

::: testing/mozharness/configs/builds/branch_specifics.py:190
(Diff revision 2)
>          },
>      },
> -    'mozilla-esr45': {
> +    'mozilla-esr52': {
>          'enable_release_promotion': True,
> -        'repo_path': 'releases/mozilla-esr45',
> +        'repo_path': 'releases/mozilla-esr52',
>          'update_channel': 'esr',

how will we differenciate in balrog between the two esr channels while we release from both of them for a period of time?
Attachment #8834402 - Flags: review?(jlund) → review+
This is the channel name which is used in MAR's metadata, balrog rule names are set in https://hg.mozilla.org/releases/mozilla-esr52/rev/57673f0994a0#l7.40
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec071aa8a8e8
Gecko-specific changes to support mozilla-esr52; r=jlund a=release DONTBUILD
One more, sha1 repacks config incoming.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8834402 [details]
Bug 1337366 - Rename ESR52 partner repack config

One more!
Attachment #8834402 - Flags: review+ → review?(jlund)
Priority: -- → P1
Comment on attachment 8834402 [details]
Bug 1337366 - Rename ESR52 partner repack config

https://reviewboard.mozilla.org/r/110368/#review116122

I think mozreview got confused but r+ to the one line diff I see with repack_manifest_url
Attachment #8834402 - Flags: review?(jlund) → review+
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70fb9299aee5
SHA1 repacks configs for ESR52 r=jlund a=release DONTBUILD
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Doh, wrong file name.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8834402 - Flags: review+ → review?(jlund)
just renaming the file
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22974497e57e
Rename ESR52 partner repack config r=jlund DONTBUILD
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.