If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Build newer libdmg-hfsplus tools

RESOLVED FIXED in Firefox 54

Status

()

Core
Build Config
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

8 months ago
Callek found in bug 1324834 that repacking a DMG on Linux wasn't working, and it turns out that the `hfsplus` tool we're using from libdmg-hfsplus wasn't preserving file permissions when it extracted files (which broke executables, obviously). There's a fix for that in this fork:
https://github.com/andreas56/libdmg-hfsplus/commit/5c92af354b279809bc64f8013805ca0b51b29960

and this branch of that fork seems to have rolled up the other fixes we're using along with those patches, so I'm going to build the tools from there:
https://github.com/andreas56/libdmg-hfsplus/tree/from_zarvox

Building them locally and running them showed that the permissions were preserved, so I'm going to build new binaries from that branch and put them in tooltool. I've had a script to build them sitting around in an unlanded changeset for a few years, so I'm going to make that into a toolchain task while I'm at it:
https://hg.mozilla.org/users/tmielczarek_mozilla.com/mc/file/33fa4827178c/testing/taskcluster/scripts/misc/libdmg-hfsplus.sh
(Assignee)

Comment 1

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfcc29b48c91
(Assignee)

Comment 2

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=756497d9502e
(Assignee)

Comment 3

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77802ad7b9c2

Comment 4

8 months ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=77802ad7b9c2

\o/ -- feel free to flag me for review.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

7 months ago
mozreview-review
Comment on attachment 8834837 [details]
bug 1337393 - add a toolchain task for building libdmg-hfsplus tools, build them from a newer branch

https://reviewboard.mozilla.org/r/110666/#review112064
Attachment #8834837 - Flags: review?(bugspam.Callek) → review+

Comment 8

7 months ago
mozreview-review
Comment on attachment 8834838 [details]
bug 1337393 - update libdmg-hfsplus tools in tooltool.

https://reviewboard.mozilla.org/r/110668/#review112154
Attachment #8834838 - Flags: review?(mshal) → review+
(Assignee)

Comment 9

7 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a01dd52f558a4b752c04958af1e635f691860aa
bug 1337393 - add a toolchain task for building libdmg-hfsplus tools, build them from a newer branch r=callek

https://hg.mozilla.org/integration/mozilla-inbound/rev/54f20a8905fef7711a3156f6d023f6aa7b530dee
bug 1337393 - update libdmg-hfsplus tools in tooltool. r=mshal

Comment 10

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6a01dd52f558
https://hg.mozilla.org/mozilla-central/rev/54f20a8905fe
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Updated

7 months ago
Blocks: 1338271
(Assignee)

Updated

6 months ago
Blocks: 1350164
(Assignee)

Updated

6 months ago
No longer blocks: 1350164
Depends on: 1350164

Updated

6 months ago
Blocks: 1351474
You need to log in before you can comment on or make changes to this bug.