1337393 - Build newer libdmg-hfsplus tools

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Callek found in bug 1324834 that repacking a DMG on Linux wasn't working, and it turns out that the `hfsplus` tool we're using from libdmg-hfsplus wasn't preserving file permissions when it extracted files (which broke executables, obviously). There's a fix for that in this fork:
https://github.com/andreas56/libdmg-hfsplus/commit/5c92af354b279809bc64f8013805ca0b51b29960

and this branch of that fork seems to have rolled up the other fixes we're using along with those patches, so I'm going to build the tools from there:
https://github.com/andreas56/libdmg-hfsplus/tree/from_zarvox

Building them locally and running them showed that the permissions were preserved, so I'm going to build new binaries from that branch and put them in tooltool. I've had a script to build them sitting around in an unlanded changeset for a few years, so I'm going to make that into a toolchain task while I'm at it:
https://hg.mozilla.org/users/tmielczarek_mozilla.com/mc/file/33fa4827178c/testing/taskcluster/scripts/misc/libdmg-hfsplus.sh

Comment 1

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfcc29b48c91

Comment 2

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=756497d9502e

Comment 3

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=77802ad7b9c2

Comment 4

[Justin Wood (:Callek)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=77802ad7b9c2

\o/ -- feel free to flag me for review.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: bug 1337393 - add a toolchain task for building libdmg-hfsplus tools, build them from a newer branch

There's not a single well-maintained fork of libdmg-hfsplus, but there are
scattered forks with various fixes. The fork + branch I've chosen here
seems to have collected the most fixes, including a specific fix we need
for repacking DMG files on Linux:
https://github.com/andreas56/libdmg-hfsplus/commit/5c92af354b279809bc64f8013805ca0b51b29960

Review commit: https://reviewboard.mozilla.org/r/110666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110666/

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: bug 1337393 - update libdmg-hfsplus tools in tooltool.

Review commit: https://reviewboard.mozilla.org/r/110668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110668/

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8834837 [details]
bug 1337393 - add a toolchain task for building libdmg-hfsplus tools, build them from a newer branch

https://reviewboard.mozilla.org/r/110666/#review112064

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8834838 [details]
bug 1337393 - update libdmg-hfsplus tools in tooltool.

https://reviewboard.mozilla.org/r/110668/#review112154

Comment 9

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a01dd52f558a4b752c04958af1e635f691860aa
bug 1337393 - add a toolchain task for building libdmg-hfsplus tools, build them from a newer branch r=callek

https://hg.mozilla.org/integration/mozilla-inbound/rev/54f20a8905fef7711a3156f6d023f6aa7b530dee
bug 1337393 - update libdmg-hfsplus tools in tooltool. r=mshal

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6a01dd52f558
https://hg.mozilla.org/mozilla-central/rev/54f20a8905fe