Closed
Bug 1337407
Opened 7 years ago
Closed 7 years ago
[RTL] Separators in Activity Stream items' context menu should be aligned to the left
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)
Firefox for Android Graveyard
Theme and Visual Design
Tracking
(firefox56 fixed)
VERIFIED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: liuche)
References
Details
(Keywords: rtl, Whiteboard: [MobileAS] 1.26)
Attachments
(3 files)
STR: 1. Install Switchboard Experiments add-on on the latest Nightly 2. In about:experiments, tap on Activity stream 3. Settings -> Advanced -> Enable Activity stream 4. Open a New Tab 5. Click on the 3 dots of one of the suggested items 6. Observe the separators AR: The separators are aligned to the right. ER: They should be aligned to the left. See attached screenshot.
Summary: [RTL] Separators in Activity Stream items' context menu should be align to the left → [RTL] Separators in Activity Stream items' context menu should be aligned to the left
Comment 1•7 years ago
|
||
I am not sure if URLs should be right-aligned. I'd prefer having the URL as well as the page title displayed according to their language, as in dir=auto.
(In reply to Tomer Cohen :tomer from comment #1) > I am not sure if URLs should be right-aligned. I'd prefer having the URL as > well as the page title displayed according to their language, as in dir=auto. I was talking about the separators, not URLs :)
Comment 3•7 years ago
|
||
Sorry. Now that I see it, I am sure you're right.
Updated•7 years ago
|
Priority: -- → P2
Whiteboard: [MobileAS]
Updated•7 years ago
|
Rank: 1
Whiteboard: [MobileAS] → [MobileAS] 1.26
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → liuche
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
Added a rotated drawable in the ldrtl (layout direction right to left) dir.
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8888607 [details] Bug 1337407 - Add rtl divider resource. https://reviewboard.mozilla.org/r/159610/#review165352 ::: mobile/android/app/src/main/res/drawable-ldltr/as_contextmenu_divider.xml:1 (Diff revision 1) > +../drawable/as_rtl_contextmenu_divider.xml nit: that file should be called `as_ltr_contextmenu_divider` because it's the ltr configuration. That being said, I'd actually prefer `as_contextmenu_divider_helper` or similar, because it's otherwise unclear that `as_contextmenu_divider` is the one that's intended to be used and `as_contextmenu_divider_helper` only exists because it's impossible to define a bidirectional drawable without it. Maybe add a comment to `as_contextmenu_divider_helper` to that effect too.
Attachment #8888607 -
Flags: review?(michael.l.comella) → review+
Updated•7 years ago
|
Iteration: --- → 1.26
Priority: P2 → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Pushed by cliu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/080aa07d32df Add rtl divider resource. r=mcomella
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/080aa07d32df
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•