|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Created attachment 8834438 [details] Separators aligned to the right STR: 1. Install Switchboard Experiments add-on on the latest Nightly 2. In about:experiments, tap on Activity stream 3. Settings -> Advanced -> Enable Activity stream 4. Open a New Tab 5. Click on the 3 dots of one of the suggested items 6. Observe the separators AR: The separators are aligned to the right. ER: They should be aligned to the left. See attached screenshot.
I am not sure if URLs should be right-aligned. I'd prefer having the URL as well as the page title displayed according to their language, as in dir=auto.
(In reply to Tomer Cohen :tomer from comment #1) > I am not sure if URLs should be right-aligned. I'd prefer having the URL as > well as the page title displayed according to their language, as in dir=auto. I was talking about the separators, not URLs :)
Sorry. Now that I see it, I am sure you're right.
Created attachment 8888608 [details] Screenshot: rtl aligned dividers Added a rotated drawable in the ldrtl (layout direction right to left) dir.
Comment on attachment 8888607 [details] Bug 1337407 - Add rtl divider resource. https://reviewboard.mozilla.org/r/159610/#review165352 ::: mobile/android/app/src/main/res/drawable-ldltr/as_contextmenu_divider.xml:1 (Diff revision 1) > +../drawable/as_rtl_contextmenu_divider.xml nit: that file should be called `as_ltr_contextmenu_divider` because it's the ltr configuration. That being said, I'd actually prefer `as_contextmenu_divider_helper` or similar, because it's otherwise unclear that `as_contextmenu_divider` is the one that's intended to be used and `as_contextmenu_divider_helper` only exists because it's impossible to define a bidirectional drawable without it. Maybe add a comment to `as_contextmenu_divider_helper` to that effect too.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/080aa07d32df Add rtl divider resource. r=mcomella