[RTL] Top Sites pager indicator in the Activity Stream should start from the right

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: ItielMaN, Assigned: maliu)

Tracking

(Blocks: 2 bugs, {rtl})

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

6 months ago
Created attachment 8834479 [details]
Top Sites items not RTL'd

STR:
1. Install Switchboard Experiments add-on on the latest Nightly
2. In about:experiments, tap on Activity stream
3. Settings -> Advanced -> Enable Activity stream
4. Open a New Tab
5. Observe the Top Sites items

AR:
The items start from the left, and the first default page is on the left

ER:
The items should start from the right, and the first default page should be on the right

See attached for more info.
(Assignee)

Updated

4 months ago
Depends on: 1321981
(Assignee)

Comment 1

4 months ago
The original TopSite page direction bug has been fixed along with depending Bug 1321981. So I will reuse this bug to fix the page indicator direction bug.

STR:
  Same as comment #0, except 5. Observer the Top Site indicator(small circle dot moves along with scroll TopSite pages)

AR:
  The page indicator starts from left in RTL context.

ER:
  The page indicator starts from right in RTL context.
Assignee: nobody → max
Summary: [RTL] Top Sites list's items in the Activity Stream should start from the right → [RTL] Top Sites pager indicator in the Activity Stream should start from the right
Comment hidden (mozreview-request)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8850117 [details]
Bug 1337440 - [RTL] Get drawing offset relatively when rtl and horizontal,

https://reviewboard.mozilla.org/r/122810/#review125046
Attachment #8850117 - Flags: review?(s.kaspari) → review+

Comment 4

4 months ago
Pushed by max@mxli.us:
https://hg.mozilla.org/integration/autoland/rev/5a84ab13274a
[RTL] Get drawing offset relatively when rtl and horizontal, r=sebastian
Backed out in https://hg.mozilla.org/integration/autoland/rev/941503eb23a6 for https://treeherder.mozilla.org/logviewer.html#?job_id=85812958&repo=autoland
Comment hidden (mozreview-request)

Comment 7

4 months ago
Pushed by max@mxli.us:
https://hg.mozilla.org/integration/autoland/rev/cd12bd482754
[RTL] Get drawing offset relatively when rtl and horizontal, r=sebastian

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cd12bd482754
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1319302
You need to log in before you can comment on or make changes to this bug.