[RTL] Top Sites pager indicator in the Activity Stream should start from the right

VERIFIED FIXED in Firefox 55

Status

()

VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: itiel_yn8, Assigned: maliu)

Tracking

(Blocks: 1 bug, {rtl})

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
STR:
1. Install Switchboard Experiments add-on on the latest Nightly
2. In about:experiments, tap on Activity stream
3. Settings -> Advanced -> Enable Activity stream
4. Open a New Tab
5. Observe the Top Sites items

AR:
The items start from the left, and the first default page is on the left

ER:
The items should start from the right, and the first default page should be on the right

See attached for more info.
(Assignee)

Updated

2 years ago
Depends on: 1321981
(Assignee)

Comment 1

2 years ago
The original TopSite page direction bug has been fixed along with depending Bug 1321981. So I will reuse this bug to fix the page indicator direction bug.

STR:
  Same as comment #0, except 5. Observer the Top Site indicator(small circle dot moves along with scroll TopSite pages)

AR:
  The page indicator starts from left in RTL context.

ER:
  The page indicator starts from right in RTL context.
Assignee: nobody → max
Summary: [RTL] Top Sites list's items in the Activity Stream should start from the right → [RTL] Top Sites pager indicator in the Activity Stream should start from the right
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8850117 [details]
Bug 1337440 - [RTL] Get drawing offset relatively when rtl and horizontal,

https://reviewboard.mozilla.org/r/122810/#review125046
Attachment #8850117 - Flags: review?(s.kaspari) → review+

Comment 4

2 years ago
Pushed by max@mxli.us:
https://hg.mozilla.org/integration/autoland/rev/5a84ab13274a
[RTL] Get drawing offset relatively when rtl and horizontal, r=sebastian
Comment hidden (mozreview-request)

Comment 7

2 years ago
Pushed by max@mxli.us:
https://hg.mozilla.org/integration/autoland/rev/cd12bd482754
[RTL] Get drawing offset relatively when rtl and horizontal, r=sebastian

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cd12bd482754
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Reporter)

Updated

2 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.