1337440 - [RTL] Top Sites pager indicator in the Activity Stream should start from the right

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Itiel]

Attachment: Top Sites items not RTL'd

STR:
1. Install Switchboard Experiments add-on on the latest Nightly
2. In about:experiments, tap on Activity stream
3. Settings -> Advanced -> Enable Activity stream
4. Open a New Tab
5. Observe the Top Sites items

AR:
The items start from the left, and the first default page is on the left

ER:
The items should start from the right, and the first default page should be on the right

See attached for more info.

Comment 1

[Max Liu [:maliu]]

The original TopSite page direction bug has been fixed along with depending Bug 1321981. So I will reuse this bug to fix the page indicator direction bug.

STR:
  Same as comment #0, except 5. Observer the Top Site indicator(small circle dot moves along with scroll TopSite pages)

AR:
  The page indicator starts from left in RTL context.

ER:
  The page indicator starts from right in RTL context.

Comment 2

[Max Liu [:maliu]]

Attachment: Bug 1337440 - [RTL] Get drawing offset relatively when rtl and horizontal,

Review commit: https://reviewboard.mozilla.org/r/122810/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122810/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8850117 [details]
Bug 1337440 - [RTL] Get drawing offset relatively when rtl and horizontal,

https://reviewboard.mozilla.org/r/122810/#review125046

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a84ab13274a
[RTL] Get drawing offset relatively when rtl and horizontal, r=sebastian

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/941503eb23a6 for https://treeherder.mozilla.org/logviewer.html#?job_id=85812958&repo=autoland

Comment 6

[Max Liu [:maliu]]

Comment on attachment 8850117 [details]
Bug 1337440 - [RTL] Get drawing offset relatively when rtl and horizontal,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122810/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd12bd482754
[RTL] Get drawing offset relatively when rtl and horizontal, r=sebastian

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd12bd482754